itest+lntest: make sure states are cleaned when tests end#7511
Merged
guggero merged 1 commit intolightningnetwork:0-16-1-stagingfrom Mar 14, 2023
Merged
Conversation
Member
Author
|
hmm should this be based on master or |
ellemouton
approved these changes
Mar 14, 2023
yyforyongyu
force-pushed
the
fix-state-check-itest
branch
from
b9f3bdc to
7cc4eb9
Compare
ellemouton
reviewed
Mar 14, 2023
guggero
approved these changes
Mar 14, 2023
Collaborator
guggero
left a comment
guggero
left a comment
There was a problem hiding this comment.
LGTM pending @ellemouton's comments 🎉
Since we don't know if RC3 will be the final one, should we base this on 0-16-1-staging instead so we can go ahead and merge it?
yyforyongyu
force-pushed
the
fix-state-check-itest
branch
from
7cc4eb9 to
07c0c76
Compare
This commit changes how the node's state is updated to make sure the test cleans up the node's state. Also `testLookupHtlcResolution` is fixed with a cleanup.
yyforyongyu
force-pushed
the
fix-state-check-itest
branch
from
07c0c76 to
20e53e8
Compare
Member
Author
|
Changed the base! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a case where the cleanup is missed and validated the state when the tests end.