config: fix bug in walletrpc interaction due to mismatched coin type#7588
Merged
guggero merged 1 commit intolightningnetwork:masterfrom Apr 11, 2023
Merged
Conversation
In this commit, we fix a bug that would cause the walletrpc on the simnet chain to not be able to respond to all RPC calls. The issue is that for the SimNet backend, within chainparams.go: https://github.com/lightningnetwork/lnd/blob/6e0a67d05bd375c4b39db53dc45df74157227a57/chainreg/chainparams.go#L45-L51, we set a new CoinType for Simnet in order to match the RegTest value. Later on, when we go to verify the on disk accounts against the in-memory cointype, we fall through to an error case as the in-memory cointype is 115, while the on disk cointype is 1. To fix this, when we know we're doing simnet mode, we'll override the cointype similar to the way we did/do for LTC. Fixes lightningnetwork#6807.
Member
Author
|
Steps to test this:
This wasn't caught in the itests as we use regtest (to have compat with a bitcoind nodes) everywhere. |
sputn1ck
approved these changes
Apr 11, 2023
guggero
approved these changes
Apr 11, 2023
Collaborator
guggero
left a comment
guggero
left a comment
There was a problem hiding this comment.
Code looks good to me 🎉
bitromortac
approved these changes
Apr 11, 2023
Collaborator
bitromortac
left a comment
bitromortac
left a comment
There was a problem hiding this comment.
Tested, thank you 🍀!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this commit, we fix a bug that would cause the walletrpc on the simnet chain to not be able to respond to all RPC calls. The issue is that for the SimNet backend, within chainparams.go:
lnd/chainreg/chainparams.go
Lines 45 to 51 in 6e0a67d
Later on, when we go to verify the on disk accounts against the in-memory cointype, we fall through to an error case as the in-memory cointype is 115, while the on disk cointype is 1.
To fix this, when we know we're doing simnet mode, we'll override the cointype similar to the way we did/do for LTC.
Fixes #6807.