docs: update remote signing docs#7593
Merged
Roasbeef merged 1 commit intolightningnetwork:masterfrom Apr 11, 2023
Merged
Conversation
With this commit we update the docs according to the latest changes that were necessary to support loop and pool (which requires all 255 internally used accounts to be imported at wallet creation time). Fixes lightningnetwork#7567.
aakselrod
approved these changes
Apr 11, 2023
Contributor
aakselrod
left a comment
aakselrod
left a comment
There was a problem hiding this comment.
This is a good doc update. For lndsigner, we export the accounts this way since the start:
https://github.com/NYDIG/lndsigner/blob/a0a6baeecf0793fe2399e46fdeb5e3df2ae96824//vault/keys.go#L19-L62
https://github.com/NYDIG/lndsigner/blob/a0a6baeecf0793fe2399e46fdeb5e3df2ae96824/vault/backend.go#L131-L163
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
With this commit we update the docs according to the latest changes that were necessary to support loop and pool (which requires all 255 internally used accounts to be imported at wallet creation time).
Fixes #7567.