funding: don't fail if we are not able to delete the fwdPolicy#7616
Closed
positiveblue wants to merge 1 commit intolightningnetwork:masterfrom
Closed
funding: don't fail if we are not able to delete the fwdPolicy#7616positiveblue wants to merge 1 commit intolightningnetwork:masterfrom
positiveblue wants to merge 1 commit intolightningnetwork:masterfrom
Conversation
In lightningnetwork#6753 we added support to custom base and fee rate fees when opening a channel. Since v0.16.0 all channels store their initial fwdPolicy even if they are using the default values. However, there is an edge case where a channel is open before migrating to >v0.16.0 but updating to +v0.16.0 before that channel gets confirmed. For those cases we won't be able to retrieve/delete the initial fwdPolicy. In that case we need to use the default values but we also need to ensure that we do not fail when trying to read/delete the initial fwdPolicy. lightningnetwork#7613 fixed the problem for reading, here we fix it for deleting.
ellemouton
reviewed
Apr 19, 2023
Comment on lines
+3241
to
3243
| if err != nil && !errors.Is(err, channeldb.ErrChannelNotFound) { | ||
| log.Infof("Could not delete channel fees "+ | ||
| "for chanId %x.", chanID) |
Collaborator
There was a problem hiding this comment.
both these cases are just logs though? not too costly to log I think
Contributor
Author
|
Oh you are right, I did not notice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #6753 we added support to custom base and fee rate fees when opening a channel. Since v0.16.0 all channels store their initial fwdPolicy even if they are using the default values. However, there is an edge case where a channel is open before migrating to >v0.16.0 but updating to +v0.16.0 before that channel gets confirmed.
For those cases we won't be able to retrieve/delete the initial fwdPolicy. In that case we need to use the default values but we also need to ensure that we do not fail when trying to read/delete the initial fwdPolicy. #7613 fixed the problem for reading, here we fix it for deleting.