Fixes #7438 (more clearly define the payment_addr field in all documentation)#7873
Closed
daredevil3435 wants to merge 3 commits into
Closed
Fixes #7438 (more clearly define the payment_addr field in all documentation)#7873daredevil3435 wants to merge 3 commits into
daredevil3435 wants to merge 3 commits into
Conversation
Author
|
@AndySchroder @guggero Please review my PR. Let me know if it requires more changes. |
Author
|
I didn't understand, what does no-itest and no-changlelog label exactly mean? @guggero |
yyforyongyu
requested changes
Aug 8, 2023
Member
yyforyongyu
left a comment
yyforyongyu
left a comment
There was a problem hiding this comment.
Thanks for the PR! These labels are used for trivial changes where no itest or release notes are needed.
Please read our contribution guidelines, formatting guides and our pull request checklist, in particular how we write the commit messages. And this is missing make rpc.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes made
This PR fixes #7438
Added -
In various situations, the payment_secret is used as an alternative term for payment_addr in required places.
Changed Files-
lnrpc/invoicesrpc/invoices.proto
lnrpc/lightning.proto
lnrpc/lightning.proto