Skip to content

Fixes #7438 (more clearly define the payment_addr field in all documentation)#7885

Open
daredevil3435 wants to merge 4 commits into
lightningnetwork:masterfrom
daredevil3435:master
Open

Fixes #7438 (more clearly define the payment_addr field in all documentation)#7885
daredevil3435 wants to merge 4 commits into
lightningnetwork:masterfrom
daredevil3435:master

Conversation

@daredevil3435
Copy link
Copy Markdown

Change Description

Fixes #7438.

Added -
In various situations, the payment_secret is used as an alternative term for payment_addr in required places.

File changes

3 files changes

  1. lnrpc/invoicesrpc/invoices.proto
  2. lnrpc/lightning.proto
  3. lnrpc/lightning.proto

@daredevil3435
Copy link
Copy Markdown
Author

@guggero @yyforyongyu please review this PR. I am new in this contribution field, so I made new PR. I am really sorry for troubling you two.

@guggero
Copy link
Copy Markdown
Collaborator

guggero commented Aug 11, 2023

It's great to see new contributors being interested in the project. But if you're new to Git and GitHub as well, then I recommend taking some time to learn the basics, that will help you with your PRs getting review time quite a bit (remember, most of the time properly reviewing a PR takes the same or more time than writing the code itself).

So please take the time to fix the following issues before we take a closer look:

  • No need to create new PRs, Git allows you to edit the content of your PR (see below)
  • You shouldn't use the "update branch" feature of GitHub, that creates unnecessary merge commits that make things harder to review. Instead please do a "rebase". There's a great tutorial here: https://www.freecodecamp.org/news/the-ultimate-guide-to-git-merge-and-git-rebase/
  • Commits of a PR should tell the story of what you want to change. Not the story of the individual iterations the PR went through. So you should probably squash all your commits into a single one (and check the contribution guides again for commit message structure).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature]: more clearly define the payment_addr field in all documentation

2 participants