Fixes #7438 (more clearly define the payment_addr field in all documentation)#7885
Open
daredevil3435 wants to merge 4 commits into
Open
Fixes #7438 (more clearly define the payment_addr field in all documentation)#7885daredevil3435 wants to merge 4 commits into
daredevil3435 wants to merge 4 commits into
Conversation
Author
|
@guggero @yyforyongyu please review this PR. I am new in this contribution field, so I made new PR. I am really sorry for troubling you two. |
Collaborator
|
It's great to see new contributors being interested in the project. But if you're new to Git and GitHub as well, then I recommend taking some time to learn the basics, that will help you with your PRs getting review time quite a bit (remember, most of the time properly reviewing a PR takes the same or more time than writing the code itself). So please take the time to fix the following issues before we take a closer look:
|
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Fixes #7438.
Added -
In various situations, the payment_secret is used as an alternative term for payment_addr in required places.
File changes
3 files changes