funding: remove dead code and sanity check pending chan ID#7887
Merged
guggero merged 3 commits intolightningnetwork:masterfrom Oct 9, 2023
Merged
funding: remove dead code and sanity check pending chan ID#7887guggero merged 3 commits intolightningnetwork:masterfrom
guggero merged 3 commits intolightningnetwork:masterfrom
Conversation
yyforyongyu
added
funding
yyforyongyu
force-pushed
the
fix-del-reservation
branch
from
17ebee1 to
dedbb04
Compare
yyforyongyu
force-pushed
the
fix-del-reservation
branch
2 times, most recently
from
9aca401 to
bdc2306
Compare
This commit removes the occurance of `newChanBarriers` as it's not used anywhere.
yyforyongyu
force-pushed
the
fix-del-reservation
branch
2 times, most recently
from
95c8583 to
79d11cb
Compare
Slightly refactored the names so it's easier to see which side is processing what messages.
This commit adds a sanity check to make sure an empty pending channel ID will not be accepted.
yyforyongyu
force-pushed
the
fix-del-reservation
branch
from
79d11cb to
23c75ae
Compare
Collaborator
|
@Crypt-iQ: review reminder |
ellemouton
approved these changes
Oct 9, 2023
| func (f *Manager) handleFundingOpen(peer lnpeer.Peer, | ||
| // | ||
| //nolint:funlen | ||
| func (f *Manager) fundeeProcessOpenChannel(peer lnpeer.Peer, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow up PR from #7518, this PR removes the unused
newChanBarriers, renames some of the methods for clarity, and adds a sanity check to make surependingChanIDis not set to zero.