Skip to content

chainntnfs: increase timeout in unit tests#8360

Closed
yyforyongyu wants to merge 1 commit into
lightningnetwork:masterfrom
yyforyongyu:fix-bitcoind-flake
Closed

chainntnfs: increase timeout in unit tests#8360
yyforyongyu wants to merge 1 commit into
lightningnetwork:masterfrom
yyforyongyu:fix-bitcoind-flake

Conversation

@yyforyongyu
Copy link
Copy Markdown
Member

Fix the unit test flake we've seen recently,

--- FAIL: TestHistoricalConfDetailsTxIndex (0.00s)
    --- FAIL: TestHistoricalConfDetailsTxIndex/rpc_polling_enabled (10.28s)
        bitcoind_test.go:126: unable to establish connection to bitcoind: method did not return within the timeout

Also remove the `t.Helper()` so it's easier to trace down the errors.
@guggero
Copy link
Copy Markdown
Collaborator

guggero commented Jan 9, 2024

I'm not sure if it's actually a question of how long we wait. A lot of tests fail on my local machine because there are port collisions. So I think this will likely be fixed with #8273 (which I should look into to fix the new failures that popped up now).

@yyforyongyu
Copy link
Copy Markdown
Member Author

I'm not sure if it's actually a question of how long we wait. A lot of tests fail on my local machine because there are port collisions. So I think this will likely be fixed with #8273 (which I should look into to fix the new failures that popped up now).

yeah i also saw port collision sometimes in lnd, but only during the shutdown process where the rpc port was not cleaned. Have not yet seen such a case in unit test tho.

@yyforyongyu yyforyongyu closed this May 2, 2024
@yyforyongyu yyforyongyu deleted the fix-bitcoind-flake branch May 2, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants