Add more RPCs for scid aliases by GeorgeTsagk · Pull Request #8509 · lightningnetwork/lnd

GeorgeTsagk · 2024-02-29T12:10:13Z

Change Description

This PR adds RPC methods that allow the user to manually edit the sets of aliases for channel scids.

Closes #8199
Closes lightninglabs/taproot-assets#786

coderabbitai · 2024-02-29T12:10:19Z

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

GeorgeTsagk · 2024-03-08T15:22:37Z

This will force the switch to read all the aliases for this link again. Maybe not ideal for big scale use cases

guggero

Code looks pretty good, nice work.
Main comment is about the defer in the link level and about where to place the two new RPCs.

guggero

Nice work, this is very close. Just need to fix a potential deadlock and find out what the problem with the itest is.

GeorgeTsagk · 2024-03-13T20:03:07Z

Updated @guggero , most of CI should also be green now, will revisit once this run is completed

guggero

Nice, LGTM 🎉

dstadulis · 2024-03-26T19:00:04Z

This PR still needs review and if a pioneering review wishes to take it, please do so.

Current review capacity is critical so intention is to include it in lnd v0.18.1

lightninglabs-deploy · 2024-05-09T19:03:45Z

@GeorgeTsagk, remember to re-request review from reviewers when ready

guggero

Sorry, one more move of the RPC... My bad, should've communicated better.

Other than that and a few minor CI related things, this is good to go 🎉

guggero

Three more small things, then we're definitely good to go!

guggero

LGTM pending resolution of this thread 🎉

guggero · 2024-05-20T16:56:59Z

Will merge this PR into the staging branch as soon as CI is green. Tracking remaining issues to address before merging into master here: #8769

Crypt-iQ · 2024-05-20T17:11:33Z

Looking at the linked issue above - not sure if you want to defer these patches to another PR, but should also check (ideally at RPC level) that:

the alias doesn't collide with a real channel (this is the up-front check - still doesn't totally negate the possibility of collision)
the passed-in base SCID also maps to a real channel that we own

GeorgeTsagk self-assigned this Feb 29, 2024

dstadulis mentioned this pull request Feb 29, 2024

[Tracking]: lnd rpc+invoices: create RPC calls allowing specify custom scid alias mappings lightninglabs/taproot-assets#786

Closed

GeorgeTsagk force-pushed the scid-alias-rpcs branch 4 times, most recently from 332fa28 to 525a8cd Compare March 8, 2024 12:34

GeorgeTsagk requested review from Crypt-iQ and guggero March 8, 2024 12:34

GeorgeTsagk marked this pull request as ready for review March 8, 2024 12:34

GeorgeTsagk commented Mar 8, 2024

View reviewed changes

guggero reviewed Mar 8, 2024

View reviewed changes

GeorgeTsagk force-pushed the scid-alias-rpcs branch 3 times, most recently from c6cbb72 to 1fa023e Compare March 12, 2024 17:32

GeorgeTsagk requested a review from guggero March 13, 2024 12:09

GeorgeTsagk commented Mar 13, 2024

View reviewed changes

Comment thread itest/lnd_routing_test.go Outdated

guggero reviewed Mar 13, 2024

View reviewed changes

GeorgeTsagk force-pushed the scid-alias-rpcs branch 3 times, most recently from 7134e7d to 781ca9e Compare March 13, 2024 20:01

GeorgeTsagk requested a review from guggero March 13, 2024 20:02

GeorgeTsagk force-pushed the scid-alias-rpcs branch from 781ca9e to cfe3f3d Compare March 13, 2024 20:41

guggero approved these changes Mar 14, 2024

View reviewed changes

Comment thread htlcswitch/switch.go Outdated

saubyk added this to the v0.18.0 milestone Mar 14, 2024

saubyk modified the milestones: v0.18.0, v0.18.1 Mar 26, 2024

GeorgeTsagk changed the base branch from master to custom-channels-integration April 23, 2024 12:07

guggero force-pushed the custom-channels-integration branch 2 times, most recently from a5d1e43 to 15abb14 Compare May 1, 2024 13:53

GeorgeTsagk force-pushed the scid-alias-rpcs branch from 604de7c to 12583fd Compare May 2, 2024 18:43

guggero force-pushed the custom-channels-integration branch from 15abb14 to 09b34f1 Compare May 14, 2024 07:49

GeorgeTsagk force-pushed the scid-alias-rpcs branch from 12583fd to 022c847 Compare May 16, 2024 09:07

GeorgeTsagk changed the base branch from custom-channels-integration to 0-19-staging May 16, 2024 09:07

GeorgeTsagk force-pushed the scid-alias-rpcs branch from 022c847 to e8fb0e6 Compare May 16, 2024 17:13

GeorgeTsagk requested a review from guggero May 16, 2024 17:15

guggero reviewed May 17, 2024

View reviewed changes

Comment thread lnrpc/lightning.proto Outdated

Comment thread lnrpc/lightning.yaml Outdated

Comment thread lntest/rpc/lnd.go Outdated

Comment thread lntest/rpc/harness_rpc.go Outdated

Comment thread aliasmgr/aliasmgr.go Outdated

Comment thread docs/release-notes/release-notes-0.18.0.md Outdated

aliasmgr: add delete local alias method

cc12fb3

GeorgeTsagk force-pushed the scid-alias-rpcs branch from e8fb0e6 to 809f9f4 Compare May 20, 2024 11:40

guggero reviewed May 20, 2024

View reviewed changes

Comment thread htlcswitch/switch.go Outdated

Comment thread lnrpc/routerrpc/router.yaml Outdated

Comment thread lnrpc/routerrpc/router_server.go Outdated

GeorgeTsagk force-pushed the scid-alias-rpcs branch from 809f9f4 to 80c5eb7 Compare May 20, 2024 14:40

GeorgeTsagk requested a review from guggero May 20, 2024 14:43

guggero approved these changes May 20, 2024

View reviewed changes

Crypt-iQ reviewed May 20, 2024

View reviewed changes

Comment thread lnrpc/routerrpc/router_server.go Outdated

Comment thread htlcswitch/switch.go Outdated

guggero force-pushed the scid-alias-rpcs branch from 80c5eb7 to 98d0a43 Compare May 20, 2024 16:44

guggero mentioned this pull request May 20, 2024

tracking: remaining cleanup to address before merging 0-19-staging branch into master #8769

Closed

10 tasks

GeorgeTsagk added 5 commits May 20, 2024 18:50

multi: refresh htlcswitch aliases on aliasmgr update

5c1b568

routerrpc: add XAddLocalChanAliases & XDeleteLocalChanAliases

9d90485

aliasmgr: add alias lifecycle test

7ace555

itest: add dynamic scid alias routing test

49f7207

docs: update release notes

d9a59c6

guggero force-pushed the scid-alias-rpcs branch from 98d0a43 to d9a59c6 Compare May 20, 2024 16:50

guggero merged commit b009db3 into lightningnetwork:0-19-staging May 20, 2024

dstadulis mentioned this pull request Jul 16, 2024

[tracking]: merge custom-channel features into lnd and litd lightninglabs/taproot-assets#1027

Closed

guggero mentioned this pull request Aug 9, 2024

[custom channels 5/5]: merge custom channel staging branch into master #8960

Merged

Conversation

GeorgeTsagk commented Feb 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Change Description

Uh oh!

coderabbitai Bot commented Feb 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

GeorgeTsagk Mar 8, 2024

Choose a reason for hiding this comment

Uh oh!

guggero left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

guggero left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

GeorgeTsagk commented Mar 13, 2024

Uh oh!

guggero left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dstadulis commented Mar 26, 2024

Uh oh!

lightninglabs-deploy commented May 9, 2024

Uh oh!

guggero left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

guggero left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

guggero left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

guggero commented May 20, 2024

Uh oh!

Crypt-iQ commented May 20, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

GeorgeTsagk commented Feb 29, 2024 •

edited

Loading

coderabbitai Bot commented Feb 29, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)