Skip to content

rpcserver+lncli: fix custom channel data encoding issue#9187

Merged
guggero merged 2 commits into
lightningnetwork:masterfrom
guggero:fix-custom-data
Oct 15, 2024
Merged

rpcserver+lncli: fix custom channel data encoding issue#9187
guggero merged 2 commits into
lightningnetwork:masterfrom
guggero:fix-custom-data

Conversation

@guggero
Copy link
Copy Markdown
Collaborator

@guggero guggero commented Oct 15, 2024

Fixes an error that occurred in lncli listchannels for non-custom channels.

Copy link
Copy Markdown
Collaborator

@ziggie1984 ziggie1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick fix 🎉

@guggero guggero requested review from ellemouton and removed request for ffranr October 15, 2024 10:48
Copy link
Copy Markdown

@dstadulis dstadulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Comment thread cmd/commands/commands.go Outdated
Comment thread rpcserver.go
Copy link
Copy Markdown
Collaborator

@ellemouton ellemouton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

@guggero guggero merged commit f0b1015 into lightningnetwork:master Oct 15, 2024
@guggero guggero deleted the fix-custom-data branch October 15, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants