itest: fix flake in payment_failure_reason_canceled#9228
Merged
Conversation
yyforyongyu
added
itests
Contributor
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
guggero
approved these changes
Oct 28, 2024
Collaborator
guggero
left a comment
guggero
left a comment
There was a problem hiding this comment.
Nice fix, LGTM (pending successful CI run) 🎉
ziggie1984
approved these changes
Oct 28, 2024
| // above a good number of confirmations. | ||
| const totalTxes = 200 | ||
| h.MineBlocksAndAssertNumTxes(numBlocksSendOutput, totalTxes) | ||
| h.MineBlocks(numBlocksSendOutput) |
Collaborator
There was a problem hiding this comment.
Hmm I don't really understand the comment of the sweeper here, because I don't think the sweeper is involved here in general, we are using the SendRawTransaction of the miner imo, but maybe I misunderstand something here.
Member
Author
There was a problem hiding this comment.
yeah my bad - it's from another PR, removed the commit msg!
Fix the case,
```
--- FAIL: TestLightningNetworkDaemon/tranche01/46-of-191/bitcoind/payment_failure_reason_canceled (20.86s)
harness.go:2113:
Error Trace: /home/runner/work/lnd/lnd/lntest/harness.go:2113
/home/runner/work/lnd/lnd/itest/lnd_payment_test.go:1183
/home/runner/work/lnd/lnd/itest/lnd_payment_test.go:1138
/home/runner/work/lnd/lnd/lntest/harness.go:396
/home/runner/work/lnd/lnd/itest/lnd_test.go:139
Error: err from HTLC interceptor stream
Test: TestLightningNetworkDaemon/tranche01/46-of-191/bitcoind/payment_failure_reason_canceled
Messages: received err from HTLC interceptor stream: rpc error: code = Unknown desc = interceptor already exists
```
yyforyongyu
force-pushed
the
fix-itest-flakes
branch
from
d98c991 to
785e058
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Peel off some commits from #9227, fix the case,