Reapply #8644 #9242
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| package batch | ||
|
|
||
| import ( | ||
| "errors" | ||
| "path/filepath" | ||
| "sync" | ||
| "testing" | ||
| "time" | ||
|
|
||
| "github.com/btcsuite/btcwallet/walletdb" | ||
| "github.com/lightningnetwork/lnd/kvdb" | ||
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func TestRetry(t *testing.T) { | ||
| dbDir := t.TempDir() | ||
|
|
||
| dbName := filepath.Join(dbDir, "weks.db") | ||
| db, err := walletdb.Create( | ||
| "bdb", dbName, true, kvdb.DefaultDBTimeout, | ||
| ) | ||
| if err != nil { | ||
| t.Fatalf("unable to create walletdb: %v", err) | ||
| } | ||
| t.Cleanup(func() { | ||
| db.Close() | ||
| }) | ||
|
|
||
| var ( | ||
| mu sync.Mutex | ||
| called int | ||
|
Member
There was a problem hiding this comment. nit: could use
Contributor
Author
There was a problem hiding this comment. I used a mutex because the underlying |
||
| ) | ||
| sched := NewTimeScheduler(db, &mu, time.Second) | ||
|
|
||
| // First, we construct a request that should retry individually and | ||
| // execute it non-lazily. It should still return the error the second | ||
| // time. | ||
| req := &Request{ | ||
| Update: func(tx kvdb.RwTx) error { | ||
| called++ | ||
|
|
||
| return errors.New("test") | ||
| }, | ||
| } | ||
| err = sched.Execute(req) | ||
|
|
||
| // Check and reset the called counter. | ||
| mu.Lock() | ||
| require.Equal(t, 2, called) | ||
| called = 0 | ||
| mu.Unlock() | ||
|
|
||
| require.ErrorContains(t, err, "test") | ||
|
|
||
| // Now, we construct a request that should NOT retry because it returns | ||
| // a serialization error, which should cause the underlying postgres | ||
| // transaction to retry. Since we aren't using postgres, this will | ||
| // cause the transaction to not be retried at all. | ||
| req = &Request{ | ||
| Update: func(tx kvdb.RwTx) error { | ||
| called++ | ||
|
|
||
| return errors.New("could not serialize access") | ||
| }, | ||
| } | ||
| err = sched.Execute(req) | ||
|
|
||
| // Check the called counter. | ||
| mu.Lock() | ||
| require.Equal(t, 1, called) | ||
| mu.Unlock() | ||
|
|
||
| require.ErrorContains(t, err, "could not serialize access") | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.