trivial: prepare itest for blockbeat#9259
Merged
guggero merged 7 commits intoNov 13, 2024
Merged
Conversation
`openChannelsForNodes` is called inside `openZeroConfChannelsForNodes` so this value can be true.
Contributor
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
yyforyongyu
force-pushed
the
prepare-itest-for-blockbeat
branch
2 times, most recently
from
e9ca4ea to
fef13b3
Compare
guggero
approved these changes
Nov 12, 2024
Collaborator
guggero
left a comment
guggero
left a comment
There was a problem hiding this comment.
Awesome work tracking down all those flakes 💯 LGTM 🎉
Fix a flake found in `testRPCMiddlewareInterceptor` when running in macOS.
This commit replaces `AssertTopologyChannelOpen` with `AssertChannelInGraph`, which asserts a given channel edge is found. `AssertTopologyChannelOpen` only asserts a given edge has been received via the topology subscription, while we need to make sure the channel is in the graph before continuing our tests.
yyforyongyu
force-pushed
the
prepare-itest-for-blockbeat
branch
from
fef13b3 to
653a8ac
Compare
ViktorT-11
approved these changes
Nov 13, 2024
| p OpenChannelParams) []*lnrpc.ChannelPoint { | ||
|
|
||
| // Sanity check the params. | ||
| require.False(h, p.ZeroConf, "zero-conf channels must be disabled") |
Collaborator
There was a problem hiding this comment.
Ah my bad! Sorry about that suggestion :/!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked commits from the final
blockbeatto reduce the PR size.This PR makes a few trivial changes to fix the flakes found in the blockbeat itest.