multi: fix rpcclient shutdown#9261
Conversation
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
guggero
left a comment
There was a problem hiding this comment.
LGTM, barring dependent PRs.
f144998 to
6dcef9c
Compare
ellemouton
left a comment
There was a problem hiding this comment.
lgtm - one suggestion :)
6dcef9c to
012d4e2
Compare
We need to call `WaitForShutdown` after stopping the rpc clients of the chain backends.
012d4e2 to
1c6d894
Compare
Cherry-picked commits from the final
blockbeatto reduce the PR size.Depends on btcsuite/btcwallet#964
Make sure we call
WaitForShutdownon the rpcclient and perform a fast exit inrecordFlapCount.