Skip to content

multi: update new walletdb version in main go.mod and kvdb go.mod#9684

Merged
guggero merged 2 commits into
lightningnetwork:masterfrom
ziggie1984:master
Apr 14, 2025
Merged

multi: update new walletdb version in main go.mod and kvdb go.mod#9684
guggero merged 2 commits into
lightningnetwork:masterfrom
ziggie1984:master

Conversation

@ziggie1984
Copy link
Copy Markdown
Collaborator

@ziggie1984 ziggie1984 commented Apr 7, 2025 •
edited
Loading

Updated to the new walletdb/v1.5.0 with the option to open a bbolt db in readonly. This changes needs to be done thorougly because the error will only be seen at runtime. Tried my best to filter all the postions where we use it. But a second pair of eyes would be very good.

After this change: the kvdb package needs to be tagged, then it could be used in the lndinit tool.

lightninglabs/lndinit#21

EDIT:

Also bumped btcwallet version.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 7, 2025

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)
  • llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ziggie1984 ziggie1984 self-assigned this Apr 7, 2025
@ziggie1984 ziggie1984 marked this pull request as ready for review April 7, 2025 22:48
@guggero
Copy link
Copy Markdown
Collaborator

guggero commented Apr 8, 2025

The wallet loader also needs to be updated, which means we need btcsuite/btcwallet#998 first.

ziggie1984
ziggie1984 commented Apr 9, 2025
View reviewed changes
Comment thread go.mod Outdated
@ziggie1984 ziggie1984 force-pushed the master branch 7 times, most recently from 8778dd0 to 314fbfb Compare April 9, 2025 14:23
ziggie1984
ziggie1984 commented Apr 9, 2025
View reviewed changes
Comment thread go.mod

retract v0.0.2

replace github.com/lightningnetwork/lnd/kvdb => ./kvdb
Copy link
Copy Markdown
Collaborator Author

@ziggie1984 ziggie1984 Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if the linter will complain because of that.

Copy link
Copy Markdown
Member

@yyforyongyu yyforyongyu Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we need to upgrade the kvdb, tag it and update the version here?

Copy link
Copy Markdown
Collaborator Author

@ziggie1984 ziggie1984 Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or merge this one, tag kvdb, and remove this entry ?

bhandras
bhandras approved these changes Apr 9, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (needs go mod tidy) ✅

ziggie1984
ziggie1984 commented Apr 9, 2025
View reviewed changes
Comment thread kvdb/interface.go

// ErrDbDoesNotExist is returned when a database instance is opened
// but it does not exist.
ErrDbDoesNotExist = walletdb.ErrDbDoesNotExist
Copy link
Copy Markdown
Collaborator Author

@ziggie1984 ziggie1984 Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so I can use only kvdb in the lndinit tool

yyforyongyu
yyforyongyu reviewed Apr 9, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@yyforyongyu yyforyongyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm weird itest failure

@yyforyongyu yyforyongyu mentioned this pull request Apr 10, 2025
Merged
@saubyk saubyk added this to the v0.19.0 milestone Apr 10, 2025
yyforyongyu
yyforyongyu approved these changes Apr 14, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@yyforyongyu yyforyongyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🐠 The only question is the kvdb tag. As for the itest failure, it's actually a bug that we are investigating atm.

@ziggie1984
Copy link
Copy Markdown
Collaborator Author

ziggie1984 commented Apr 14, 2025

hmmm weird itest failure

I looked into it, it seems not related to this new code change, but rather a race condition in the notifier logic, so I think we can merge this.

@guggero guggero merged commit 6d648ad into lightningnetwork:master Apr 14, 2025
89 of 97 checks passed
@guggero guggero mentioned this pull request Apr 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bhandras bhandras bhandras approved these changes

@yyforyongyu yyforyongyu yyforyongyu approved these changes

Assignees

@ziggie1984 ziggie1984

Labels

dependencies no-changelog

Projects

None yet

Milestone

v0.19.0

Development

Successfully merging this pull request may close these issues.

5 participants

@ziggie1984 @guggero @bhandras @yyforyongyu @saubyk