Fix Claude Code plugin#10
Open
greenrd wants to merge 1 commit into
Open
Conversation
It had two issues: 1. The skills field is supposed to point to a parent directory of a directory (or more than one directory) containing a SKILL.md file. 2. $HOME doesn't get expanded in `mcpServers.lightpanda.command`.
staylor
added a commit
to staylor/agent-skill
that referenced
this pull request
May 5, 2026
Three small unrelated factual corrections, grouped because they are all docs-only one-liners. 1. MCP path resolution (addresses point 2 of lightpanda-io#10) - Claude Code CLI form: "$(command -v lightpanda)" resolves the absolute path at install time, regardless of where the binary lives. - JSON config form: literal /absolute/path/to/lightpanda placeholder with instruction to fill it in via command -v lightpanda. No per-OS examples (those would presuppose the install method, which varies). This does NOT close lightpanda-io#10 — only the second bullet of greenrd's issue. Point 1 (the 'skills' field in marketplace.json) is a different file this PR doesn't touch. 2. CDP connection limit The Important Notes bullet said 'Only 1 CDP connection per process'. Current Lightpanda defaults to 16 and exposes --cdp-max-connections N to tune it. Updates the bullet and adds the flag to the lightpanda serve options list. 3. Playwright connectOverCDP signature Both Playwright overloads (string and object) work in playwright-core 1.58, but Playwright's own JSDoc Usage examples and published docs use the string form (chromium.connectOverCDP('ws://...')). This is a style preference, not a bug — happy to drop or split out.
staylor
added a commit
to staylor/agent-skill
that referenced
this pull request
May 5, 2026
Three small unrelated factual corrections, grouped because they are all docs-only one-liners. 1. MCP path resolution (addresses point 2 of lightpanda-io#10) - Claude Code CLI form: "$(command -v lightpanda)" resolves the absolute path at install time, regardless of where the binary lives. - JSON config form: literal /absolute/path/to/lightpanda placeholder with instruction to fill it in via command -v lightpanda. No per-OS examples (those would presuppose the install method, which varies). This does NOT close lightpanda-io#10 — only the second bullet of greenrd's issue. Point 1 (the 'skills' field in marketplace.json) is a different file this PR doesn't touch. 2. CDP connection limit The Important Notes bullet said 'Only 1 CDP connection per process'. Current Lightpanda defaults to 16 and exposes --cdp-max-connections N to tune it. Updates the bullet and adds the flag to the lightpanda serve options list. 3. Playwright connectOverCDP signature Both Playwright overloads (string and object) work in playwright-core 1.58, but Playwright's own JSDoc Usage examples and published docs use the string form (chromium.connectOverCDP('ws://...')). This is a style preference, not a bug — happy to drop or split out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It had two issues:
mcpServers.lightpanda.command.