-
Notifications
You must be signed in to change notification settings - Fork 3
Add Suisse Intl font system with typography updates #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add Suisse Intl: Regular, Book (buttons), Medium (bold/headings) - Add Suisse Intl Mono for code blocks - Remove Bold font (Medium used for bold instead) - Apply fonts globally with font-feature-settings "salt" for single-story A - Use font-display: block to prevent FOUT - Preload all font files in docs.json
- Configure fonts in docs.json (Mintlify's recommended approach) - Add Medium weight (500) for headings, bold text, navigation, buttons - Add Mono Bold for API field names - Use semantic selectors (data-component-part, IDs, Mintlify classes) - Fix homepage footer alignment - Remove text-shadow faux-bold effects from navigation
Greptile SummaryThis PR establishes a comprehensive Suisse Intl font system for the Mintlify documentation site, configuring custom fonts through Mintlify's recommended Key changes:
Minor observation:
Confidence Score: 5/5
|
| Filename | Overview |
|---|---|
| mintlify/docs.json | Added Mintlify fonts config for heading/body fonts and updated font preload links to include new mono fonts and Book weight |
| mintlify/styles/fonts.css | Added Book (450) and Mono font-face declarations, mapped bold (700) to Medium, changed font-display to block. Book weight (450) is defined but unused. |
| mintlify/styles/styles.css | Added comprehensive typography styling for headings, navigation, code blocks, and homepage elements. Removed redundant font-family declarations. |
| mintlify/index.mdx | Restructured footer to use .section wrapper for consistent alignment with other content sections |
Sequence Diagram
sequenceDiagram
participant Browser
participant Mintlify as Mintlify Server
participant Fonts as Font Files
Browser->>Mintlify: Request page
Mintlify->>Browser: Return HTML with preload links
par Font Preloading
Browser->>Fonts: Preload SuisseIntl-Regular.woff2
Browser->>Fonts: Preload SuisseIntl-Book.woff2
Browser->>Fonts: Preload SuisseIntl-Medium.woff2
Browser->>Fonts: Preload SuisseIntlMono-Regular-WebXL.woff2
Browser->>Fonts: Preload SuisseIntlMono-Bold-WebXL.woff2
end
Browser->>Mintlify: Load fonts.css
Mintlify->>Browser: @font-face declarations
Browser->>Mintlify: Load styles.css
Mintlify->>Browser: Typography rules applied
Note over Browser: font-display: block<br/>prevents FOUT
Greptile found no issues!From now on, if a review finishes and we haven't found any issues, we will not post anything, but you can confirm that we reviewed your changes in the status check section. This feature can be toggled off in your Code Review Settings by deselecting "Create a status check for each PR". |
Wrap footer in same usecase/section structure as other homepage sections so it aligns with cards on wide screens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 files reviewed, 1 comment
| /* Book (450) - Button text */ | ||
| @font-face { | ||
| font-family: "Suisse Intl"; | ||
| src: url("/fonts/suisse-intl/SuisseIntl-Book.woff2") format("woff2"); | ||
| font-weight: 450; | ||
| font-style: normal; | ||
| font-display: block; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Book weight (450) is defined and preloaded but not used anywhere in the CSS. Consider using it for buttons as the comment suggests, or remove to reduce font loading overhead.
Prompt To Fix With AI
This is a comment left during a code review.
Path: mintlify/styles/fonts.css
Line: 14:21
Comment:
**style:** Book weight (450) is defined and preloaded but not used anywhere in the CSS. Consider using it for buttons as the comment suggests, or remove to reduce font loading overhead.
How can I resolve this? If you propose a fix, please make it concise.
Summary
Font Weights
Test plan