Convert gotest to pytest #3
Conversation
changli2023
requested review from
jklein24,
vdurmont,
waterson and
yunyuyunyu
changli2023
force-pushed
the
gotest2pytest
branch
from
ec1c15e to
4dc928b
Compare
waterson
left a comment
waterson
left a comment
There was a problem hiding this comment.
I think it's good that we have these tests in the Python SDK, because -- sure, we'll want to test the Python SDK.
But won't we eventuallyl need some internal version of this that allows us to use the sparkcore APIs for more elaborate testing?
| tx = wait_for_payment_completion(client, payment.id) | ||
| assert tx.status != lightspark.TransactionStatus.FAILED, "Payment failed!" | ||
| log.info(tx) | ||
| log.info("===test_funding_node1===SUCCEEDED\n") |
There was a problem hiding this comment.
Does this actually print out anything when running as a pytest? (Do we need it to? Isn't the fact that the test passed sufficient?)
lightspark/__tests__/test_config.py
Outdated
There was a problem hiding this comment.
Do we actually want to check this in to the SDK? Isn't this going to be public? Not that the keys are super secret or anything, but... seems weird that we'd put this into the SDK. For example, if we have to recreate the nodes / change keys we'll need to do an SDK release, right?
changli2023
force-pushed
the
gotest2pytest
branch
from
06cc9fa to
1a7c1b7
Compare
|
|
|
The PR is closed since we do not put the pytest in the python sdk. |
No description provided.