Modify close behavior to block until a satellite sends a response#223
Merged
Conversation
jmacd
approved these changes
Nov 28, 2019
| std::mutex shutdown_mutex_; | ||
| std::condition_variable shutdown_condition_variable_; | ||
| std::atomic<int> shutdown_counter_{0}; | ||
| bool last_is_active_{true}; |
Contributor
There was a problem hiding this comment.
I had a bit of trouble following what this variable does. Could you add a comment? Maybe add a comment on ShutdownWithTimeout to explain why it can fail even without a timeout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #219