Add more performant manual recorder#231
Merged
Merged
Conversation
jmacd
approved these changes
Feb 3, 2020
Contributor
jmacd
left a comment
jmacd
left a comment
There was a problem hiding this comment.
The changes look good. I'm wondering how users will follow all the options available in this code. For example, is there any document that describes all the recorder options?
|
|
||
| namespace lightstep { | ||
| /** | ||
| * BufferChain provides an interface to access a chained sequestion of |
Contributor
Author
You can't set recorder options directly, but there's documentation for all the tracer options. https://github.com/rnburn/lightstep-tracer-cpp/blob/manual-v2/include/lightstep/tracer.h#L52 I mostly wanted to keep the LegacyManualTransporter around so that we have an easy way to benchmark the two approaches for building up the report request protobuf message |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a replacement for the existing manual tracer that provides better performance.
In benchmarking, it has around a 2x-5x improvement