Add support for x-cloud-trace-context#248
Merged
Merged
Conversation
… the x-cloud-trace-context header
…trace_id & trace_id/span_id formats
…e should do when no span ID is provided)
…e correct behaviour)
rnburn
reviewed
Aug 5, 2020
rnburn
reviewed
Aug 5, 2020
rnburn
reviewed
Aug 5, 2020
rnburn
reviewed
Aug 5, 2020
rnburn
reviewed
Aug 5, 2020
rnburn
reviewed
Aug 5, 2020
rnburn
reviewed
Aug 5, 2020
rnburn
reviewed
Aug 5, 2020
rnburn
reviewed
Aug 8, 2020
rnburn
reviewed
Aug 8, 2020
rnburn
reviewed
Aug 8, 2020
rnburn
reviewed
Aug 11, 2020
rnburn
reviewed
Aug 11, 2020
rnburn
reviewed
Aug 11, 2020
rnburn
reviewed
Aug 12, 2020
| parent_id[span_id_length] = s[offset]; | ||
| ++offset; | ||
| } | ||
| parent_id[span_id_length] = '\0'; |
Contributor
There was a problem hiding this comment.
Change to parent_id.back() = '\0';
Contributor
Author
There was a problem hiding this comment.
Had to undo this as it broke one of the tests - specifically one that send a short span ID of 123 - I think the null terminator was not being added on the end of the number i.e. 123\0 but at the end of the char array.
rnburn
reviewed
Aug 12, 2020
rnburn
reviewed
Aug 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for Google's
x-cloud-trace-contextheader.TODO Establish correct Span ID behaviour for when only a Trace ID is given in the header