Skip to content

Add DisableCacheDb annotation#484

Merged
alexislefebvre merged 1 commit intoliip:2.xfrom
magnetik:cache-db
Mar 2, 2019
Merged

Add DisableCacheDb annotation#484
alexislefebvre merged 1 commit intoliip:2.xfrom
magnetik:cache-db

Conversation

@magnetik
Copy link
Copy Markdown
Contributor

@magnetik magnetik commented Jan 16, 2019 •
edited
Loading

It's #480 !

I did a little cleanup of some @IgnoreAnnotation missing.

@magnetik magnetik force-pushed the cache-db branch 8 times, most recently from e151c13 to 8464d7d Compare January 16, 2019 12:43
@alexislefebvre alexislefebvre added this to the 2.0 milestone Jan 16, 2019
@alexislefebvre
Copy link
Copy Markdown
Collaborator

alexislefebvre commented Jan 16, 2019

LGTM, thanks!

@alexislefebvre
Copy link
Copy Markdown
Collaborator

alexislefebvre commented Jan 22, 2019

Could you please add @DisableCacheDb() in https://github.com/liip/LiipFunctionalTestBundle/blob/2.x/CHANGELOG.md ?

I'm wondering now, should it be called @DisableDbCache() or a move verbose name @DisableDatabaseCache()?

@magnetik
Copy link
Copy Markdown
Contributor Author

magnetik commented Jan 23, 2019

I did DisableCacheDb to mirror the config that is called cache_db. I was not so pleased about the name but @DisableDatabaseCache looks much better

@magnetik
Copy link
Copy Markdown
Contributor Author

magnetik commented Jan 24, 2019

I've renamed the annotation

@alexislefebvre
Copy link
Copy Markdown
Collaborator

alexislefebvre commented Jan 24, 2019

Great, thanks for the PR and the changes!

@magnetik
Copy link
Copy Markdown
Contributor Author

magnetik commented Feb 26, 2019

Not so much hype about this change, but can this be shipped in an new alpha to see if it can get more traction?

@alexislefebvre alexislefebvre merged commit 0b05698 into liip:2.x Mar 2, 2019
@alexislefebvre
Copy link
Copy Markdown
Collaborator

alexislefebvre commented Mar 2, 2019

Thanks for the reminder, the PR is merged and a new version has been published: https://github.com/liip/LiipFunctionalTestBundle/releases/tag/2.0.0-alpha14

This was referenced Mar 10, 2019
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexislefebvre alexislefebvre alexislefebvre approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@magnetik @alexislefebvre