Remove Mix::Clip#124
Merged
DJMcNab merged 6 commits intolinebender:mainfrom Oct 17, 2025
Merged
Conversation
nicoburns
approved these changes
Sep 29, 2025
Contributor
nicoburns
left a comment
nicoburns
left a comment
There was a problem hiding this comment.
Looks good to me. Might be nice to create macro(s) for the bytemuck tests, so that the logic for checking the impls is only in one place.
Member
Author
|
I think the discussion from last week (#office hours > 2025-09-25) still stands, that we should instead get this marked as deprecated in Peniko v0.5, and then remove it shortly thereafter. |
github-merge-queue Bot
pushed a commit
to linebender/vello
that referenced
this pull request
Sep 29, 2025
This is already covered by our existing tests, including `many_clips` Corresponds to linebender/peniko#124
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also re-orders the
bytemucktests to be in alphabetical order.See discussion in #vello > Mix::Clip optimisation: Interaction with layers.
This is of course still useful functionality, but it does not belong in
Peniko; instead, renderers wishing to expose this optimisation should do so individually.This PR cannot be merged until a PR integrating this has been opened in Vello.