Conversation
This applies updates for the gradient API in peniko and pins the git dependency so prevent further breakage. Also removes Cargo.lock.
raphlinus
left a comment
raphlinus
left a comment
There was a problem hiding this comment.
The gradient changes look fine, thanks!
| smallvec = "1.8.0" | ||
| moscato = { git = "https://github.com/dfrg/pinot" } | ||
| peniko = { git = "https://github.com/linebender/peniko" } | ||
| peniko = { git = "https://github.com/linebender/peniko", rev = "ba96b90" } |
There was a problem hiding this comment.
Do we want to pin the one above as well?
There was a problem hiding this comment.
We can but I don't plan any further updates to moscato and it will go away as soon as googlefonts/fontations#191 lands.
There was a problem hiding this comment.
Added a pin just for consistency. Doesn't hurt!
| @@ -1 +1,2 @@ | |||
| /target | |||
| Cargo.lock | |||
There was a problem hiding this comment.
I'm not 100% sure what to do with this - having it for purely library use is not useful, but a nontrivial amount of development is the examples. I think ok to drop it as you've done here, but I'm curious if other people have thoughts.
There was a problem hiding this comment.
I don't have strong feelings on this, but I think I'll merge as to move forward and ask for commentary on zulip.
There was a problem hiding this comment.
The Cargo book has an answer as to what to do with Cargo.lock:
https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html
If you’re building a non-end product, such as a rust library that other rust packages will depend on, put
Cargo.lockin your.gitignore. If you’re building an end product, which are executable like command-line tool or an application, or a system library with crate-type ofstaticliborcdylib, checkCargo.lockintogit.
It then links to this section of their FAQ which explains the reasoning behind this.
Thus (and I'm quite surprised myself as I believed the contrary until I searched it up just now) it seems like ignoring Cargo.lock for Xilem is actually a good idea.
This follows the guidance in https://blog.rust-lang.org/2023/08/29/committing-lockfiles.html Previous discussion in linebender#256
3 participants
This applies updates for the gradient API in peniko and pins the git dependency so prevent further breakage. Also removes Cargo.lock.