Skip to content

Switches us to concat_sourcemap#190

Merged
searls merged 3 commits intomasterfrom
concat_sourcemap
Jan 17, 2014
Merged

Switches us to concat_sourcemap#190
searls merged 3 commits intomasterfrom
concat_sourcemap

Conversation

@searls
Copy link
Copy Markdown
Member

@searls searls commented Jan 17, 2014

Resolves #187

Could use a little review maybe, especially b/c this will impact existing plugins, templates, and projects that have already disabled the concat task.

@searls
Copy link
Copy Markdown
Member Author

searls commented Jan 17, 2014

FYI, the lineman-angular plugin (and anything else we've published already on concat_sourcemap will need to be remediated like so:

  • Patch bump and lock to the current minor version of lineman
  • Minor bump and upgrade to the lineman that introduces this feature
  • Right now, it uses an ngtemplates file property name to include those, but that'll need to be replaced by overriding files.template.generated instead, which strikes me as more proper anyway.

searls added a commit that referenced this pull request Jan 17, 2014
@searls searls merged commit 69da185 into master Jan 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade lineman core to concat_sourcemap instead of concat?

1 participant