Add MODEL_TO_LIGER_KERNEL_PATCHING_FUNC to minimize dependencies from external code#40
Closed
JasonZhu1313 wants to merge 1 commit intomainfrom
Closed
Add MODEL_TO_LIGER_KERNEL_PATCHING_FUNC to minimize dependencies from external code#40JasonZhu1313 wants to merge 1 commit intomainfrom
JasonZhu1313 wants to merge 1 commit intomainfrom
Conversation
ByronHsu
reviewed
Aug 17, 2024
Contributor
ByronHsu
left a comment
There was a problem hiding this comment.
makes sense to me. let's wait for hf team
Contributor
|
duplicated w #42 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add MODEL_TO_LIGER_KERNEL_PATCHING_FUNC to minimize dependencies from external code
huggingface/transformers#32860 this is the PR for integrate liger kernel to HF, to minimize the dependencies, we shall only expose the dict
Testing Done
Tested in huggingface/transformers#32860 this is the PR for integrate liger kernel to HF, to minimize the dependencies
make testto ensure correctnessmake checkstyleto ensure code stylemake test-convergenceto ensure convergence