Refactor MypyTask and MypyExtension for local customizations#311
Merged
warsaw merged 2 commits intolinkedin:masterfrom Aug 8, 2019
Merged
Refactor MypyTask and MypyExtension for local customizations#311warsaw merged 2 commits intolinkedin:masterfrom
warsaw merged 2 commits intolinkedin:masterfrom
Conversation
If and when python/mypy#7219 lands, we will have the ability to tell mypy to traverse into PEP 420 namespace packages. In order to preserve backward compatibility, the MypyExtension now allows clients to set the mypy command line arguments, but if they don't it will use the old command line of just passing the source directory.
warsaw
changed the title
warsaw
changed the title
Contributor
Author
|
Upstream mypy has accepted and merged my changes. In preparation for the next release, this is branch is ready for review. |
* The mypy extension only collects and returns the argument list; if it's null then it's up to the task to provide defaults. * Revert the addition of the `project` argument to MypyExtension's ctor.
zvezdan
approved these changes
Aug 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If and when python/mypy#7219 lands, we will have the
ability to tell mypy to traverse into PEP 420 namespace packages. In order to
preserve backward compatibility, the MypyExtension now allows clients to set
the mypy command line arguments, but if they don't it will use the old command
line of just passing the source directory.