Skip to content

feat: shallow clone in argo repo server#2977

Open
Ani1357 wants to merge 10 commits intomainfrom
APL-1491
Open

feat: shallow clone in argo repo server#2977
Ani1357 wants to merge 10 commits intomainfrom
APL-1491

Conversation

@Ani1357
Copy link
Contributor

@Ani1357 Ani1357 commented Feb 24, 2026

📌 Summary

🔍 Reviewer Notes

🧹 Checklist

  • Code is readable, maintainable, and robust.
  • Unit tests added/updated

@svcAPLBot
Copy link
Contributor

svcAPLBot commented Feb 24, 2026

Comparison of Helm chart templating output:

@@ metadata.labels.argocd.argoproj.io/secret-type @@
# v1/Secret/argocd/argocd-repo-creds-gitea
! ± value change
- repo-creds
+ repository

@@ metadata.labels.argocd.argoproj.io/secret-type @@
# v1/Secret/argocd/argocd-repo-creds-gitea-internal
! ± value change
- repo-creds
+ repository

@@ (root level) @@
# v1/Secret/argocd/argocd-repo-apl-core
! + one document added:
+ ---
+ # Source: raw/templates/resources.yaml
+ apiVersion: v1
+ data:
+   name: YXBsLWNvcmU=
+   url: aHR0cHM6Ly9naXRodWIuY29tL2xpbm9kZS9hcGwtY29yZS5naXQ=
+   depth: MQ==
+   project: ZGVmYXVsdA==
+   type: Z2l0
+ kind: Secret
+ metadata:
+   name: argocd-repo-apl-core
+   namespace: argocd
+   labels:
+     app: raw
+     app.kubernetes.io/instance: argocd-artifacts
+     app.kubernetes.io/managed-by: Helm
+     app.kubernetes.io/name: raw
+     app.kubernetes.io/part-of: otomi
+     app.kubernetes.io/version: 0.2.3
+     argocd.argoproj.io/secret-type: repository
+     helm.sh/chart: raw-0.2.3


@j-zimnowoda j-zimnowoda changed the title feat: using shallow clone in argo repo server and removing targetCPUUtilizationPercentage feat: shallow clone in argo repo server Feb 25, 2026
Copy link
Contributor

@j-zimnowoda j-zimnowoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is memory usage improvement by around 60MB

Image

Also cross-checked the labels with the documentation: https://github.com/bitnami-labs/sealed-secrets#sealedsecrets-as-templates-for-secrets

All good.

@j-zimnowoda j-zimnowoda enabled auto-merge (squash) February 25, 2026 12:57
argocd.argoproj.io/secret-type: repository
data:
type: {{ print "git" | b64enc | quote }}
url: {{ printf "https://%s" $v._derived.giteaDomain | b64enc }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed that argocd is reporting issues while connecting via public gitea url. The main branch does not carry this problem.

Image

@CasLubbers
Copy link
Contributor

The result of the failing repositories is that my applications stay in unknown with the following error:
ComparisonError
Failed to load target state: failed to generate manifest for source 1 of 1: rpc error: code = Unknown desc = failed to list refs: authentication required: Unauthorized
Screenshot 2026-02-25 at 3 40 02 PM

Copy link
Contributor

@CasLubbers CasLubbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants