Conversation
j-zimnowoda
left a comment
j-zimnowoda
left a comment
There was a problem hiding this comment.
-
I have successfully deployed. ✅
-
I like the fact that it is using istio sidecar, so mTLS can be set between communicating parties. ✅
-
I am wondering if mtls should be enforced though
⚠️ -
I was also able to clone the repo::white_check_mark:
kubectl port-forward --namespace git-server svc/git-server 9090:80
git clone http://127.0.0.1:9090/otomi/values.git
kubectl get secret git-server-credentials -n git-server -o jsonpath='{.data.password}'
- After enabling gitea things get messy, so fine tuning needs to be done so the platform does not try to switch to gitea.
⚠️
| repoName: otomi/values.git | ||
|
|
||
| image: | ||
| repository: docker.io/clubbers1892/simple-git-server |
There was a problem hiding this comment.
Once PoC is approved we will host it at docker.io/linode
| pullPolicy: IfNotPresent | ||
|
|
||
| persistence: | ||
| size: 1Gi |
There was a problem hiding this comment.
256Mi should be more than enough
|
|
||
| releases: | ||
| - name: git-server | ||
| installed: {{ not ($a | get "gitea.enabled") }} |
There was a problem hiding this comment.
pls, make it independent from git.
The git-server is going to be default mode. It should be possible to switch it to Gitea but that falls into to BYO git procedure and should not differ from switching to Github or other 3rd party provider.
| - | | ||
| if [ ! -d /data/{{ .Values.repoName }} ]; then | ||
| mkdir -p /data/{{ dir .Values.repoName }} | ||
| git init --bare --initial-branch=main /data/{{ .Values.repoName }} |
There was a problem hiding this comment.
This branch needs to be configurable
| initImage: | ||
| git: | ||
| repository: alpine/git | ||
| tag: latest |
There was a problem hiding this comment.
We should use a pinned tag instead of latest.
| kind: PersistentVolumeClaim | ||
| metadata: | ||
| name: git-server-data | ||
| namespace: {{ .Release.Namespace }} |
There was a problem hiding this comment.
| namespace: {{ .Release.Namespace }} | |
| namespace: {{ .Release.Namespace }} | |
| annotations: | |
| "helm.sh/resource-policy": keep |
Should we add this annotation to prevent data loss?
4 participants
📌 Summary
🔍 Reviewer Notes
🧹 Checklist