Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the values migration logic to avoid re-enabling Argo CD auto-sync during a PVC migration, aiming to ensure Valkey PVCs get the correct storage class during upgrades and leaving sync handling to apl-operator.
Changes:
- Deletes matching PVCs earlier in the migration flow (after scaling down and waiting for pods to terminate).
- Removes the logic that re-enabled Argo CD auto-sync at the end of the migration.
ferruhcihan
reviewed
Apr 7, 2026
ferruhcihan
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
This PR fixes the storage class for valkey being set correctly during an upgrade by stopping the enabling of the auto sync during the migration and let apl-operator handle it.