fix completion generation #608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rui Chen <rui@chenrui.dev>
chenrui333
requested review from
jriddle-linode and
lgarber-akamai
and removed request for
a team
Member
|
Hi @chenrui333, thank you so much for the PR! Can you do a |
Contributor
Author
|
should be good now. |
lgarber-akamai
approved these changes
May 2, 2024
Contributor
lgarber-akamai
left a comment
lgarber-akamai
left a comment
There was a problem hiding this comment.
Tested locally by removing my local config, unsetting LINODE_CLI_TOKEN, and running linode-cli completions bash. Thank you for the contribution!
jriddle-linode
approved these changes
May 2, 2024
jriddle-linode
added
the
improvement
Contributor
Author
|
would be good to make a followup patch release :) |
Contributor
Patch released with v5.49.1. Thanks for the contributions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
fix completion generation
closes #607
✔️ How to Test