Allow overriding spec when manually triggering E2E test workflow #664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgarber-akamai
added
the
repo-ci-improvement
vshanthe
requested review from
ezilber-akamai and
ykim-akamai
and removed request for
ykim-akamai
ykim-akamai
reviewed
Nov 12, 2024
| module: | ||
| description: "The module from 'test/integration' to the target to be tested, e.g. 'cli, domains, events, etc'" | ||
| test_path: | ||
| description: "The path from 'test/integration' to the target to be tested, e.g. 'cli'" |
Contributor
There was a problem hiding this comment.
We might want to take what is in dev for this. I personally think module make things a bit more simpler
ykim-akamai
reviewed
Nov 12, 2024
| sha: | ||
| description: 'The hash value of the commit.' | ||
| required: true | ||
| required: false |
Contributor
There was a problem hiding this comment.
I think we might want to leave this as it is
ykim-akamai
reviewed
Nov 12, 2024
| runs-on: ubuntu-latest | ||
| if: github.event_name == 'workflow_dispatch' && inputs.sha != '' || github.event_name == 'push' || github.event_name == 'pull_request' | ||
| steps: | ||
| - name: Validate Test Path |
Contributor
There was a problem hiding this comment.
I think you might have merged older local version of dev branch
Contributor
Author
There was a problem hiding this comment.
yes , raised the new PR
Contributor
|
Might want to revert the latest push with resolving merge conflicts and take changes from the latest dev |
ykim-akamai
reviewed
Nov 12, 2024
| }); | ||
| return result; | ||
| apply-calico-rules: |
Contributor
There was a problem hiding this comment.
These jobs were recently added, let's keep these jobs as it makes the workflow easier to read
Contributor
Author
|
closing this PR - #679 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Maintainers can manually specify the URL of an OpenAPI spec to use when dispatching the E2E test workflow
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.