Override placement group view to display members #675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yec-akamai
requested review from
jriddle-linode and
lgarber-akamai
and removed request for
a team
yec-akamai
commented
Nov 5, 2024
| return image_replicate_output(json_data) | ||
|
|
||
|
|
||
| @output_override("placement", "group-view", OutputMode.table) |
Contributor
Author
There was a problem hiding this comment.
I didn't override the placement groups-list output here, because I think the list view is already huge itself if user have multiple PGs, and we can try to keep it simple. User can check the members details in a single PG view. Let me know if you have different thoughts!
lgarber-akamai
approved these changes
Nov 5, 2024
Contributor
lgarber-akamai
left a comment
lgarber-akamai
left a comment
There was a problem hiding this comment.
The nested table is super clean, nice work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Implement output override to display the complex members list in placement group result.
Override the following commands:
✔️ How to Test
Expected view:
