test: Improve flaky reboot instance test; Implement retry for execute test command function #676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykim-akamai
requested review from
ezilber-akamai and
yec-akamai
and removed request for
a team
Contributor
Author
|
Got a green build :) - https://github.com/linode/linode-cli/actions/runs/11708470979/job/32610300300 |
yec-akamai
reviewed
Nov 12, 2024
Contributor
yec-akamai
left a comment
yec-akamai
left a comment
There was a problem hiding this comment.
Tests passed locally! A few small suggestions:
ezilber-akamai
approved these changes
Nov 12, 2024
Contributor
ezilber-akamai
left a comment
ezilber-akamai
left a comment
There was a problem hiding this comment.
Tests passing locally!
yec-akamai
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
test_reboot_linodetest has been failing intermittently quiet often. This PR implements some wait conditions and retry function to hopefully stabilize the test.✔️ How to Test
make TEST_CASE="test_reboot_linode" testint📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.