test: Add test coverage for Disk Encryption, Config, and Disk #677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykim-akamai
requested review from
ezilber-akamai and
jriddle-linode
and removed request for
a team
Contributor
Author
|
Disk encryption is not available in all regions. Putting the PR in draft for now |
ykim-akamai
commented
Nov 7, 2024
| delete_target_id(target="nodebalancers", id=nodebalancer_id) | ||
|
|
||
|
|
||
| def get_regions_with_capabilities(capabilities): |
Contributor
Author
There was a problem hiding this comment.
Refactored and moved to helpers.py
ykim-akamai
changed the title
ezilber-akamai
approved these changes
Nov 12, 2024
Contributor
ezilber-akamai
left a comment
ezilber-akamai
left a comment
There was a problem hiding this comment.
LGTM! Tests passing locally.
jriddle-linode
approved these changes
Nov 15, 2024
Collaborator
jriddle-linode
left a comment
jriddle-linode
left a comment
There was a problem hiding this comment.
LGTM, working locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Added Integration coverage :
CI improvement:
run_long_testsNotable refactors and test functions:
get_random_region_with_capsfunction tohelper.pyget_disk_idsto return disk ids inhelpers_linodes.pyretry_exec_test_command_with_delayfunction to retry command in case when particular instance/source is not ready✔️ How to Test
make MODULE=lke testintmake MODULE=vpc testintmake MODULE=linodes/test_rebuild.py RUN_LONG_TESTS=True testintmake MODULE="linodes/test_configs.py" testintmake MODULE="linodes/test_disk.py" testint📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.