Account for edge case where apiVersion param has no default #678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgarber-akamai
requested review from
ezilber-akamai and
ykim-akamai
and removed request for
a team
ezilber-akamai
approved these changes
Nov 12, 2024
Contributor
ezilber-akamai
left a comment
ezilber-akamai
left a comment
There was a problem hiding this comment.
Unit and manual testing worked properly. Nice work!
ykim-akamai
approved these changes
Nov 14, 2024
Contributor
ykim-akamai
left a comment
ykim-akamai
left a comment
There was a problem hiding this comment.
LGTM, verified locally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This pull request adds logic to account for an edge case where the apiVersion parameter exists but has no defined default, causing
OpenAPIOperation._resolve_api_version(...)to fail. This error is occurring when building against a pre-release version of the OpenAPI spec.✔️ How to Test
The following test steps assume you have pulled down this PR locally and run
make install.Unit Testing
Manual Testing