Skip to content

Conversation

@ykim-akamai
Copy link
Contributor

@ykim-akamai ykim-akamai commented Nov 19, 2024

📝 Description

This PR address failures in latest CLI integration test runs:

  • Test image linode/alpine3.16 is not available anymore hence updating the test image in SSH tests
  • VLAN help message changed slightly so assertion was updated

✔️ How to Test

make MODULE="ssh" testint
make TEST_CASE="test_list_vlans_help_menu -v" testint

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

@ykim-akamai ykim-akamai added the testing for updates to the testing suite in the changelog. label Nov 19, 2024
@ykim-akamai ykim-akamai requested a review from a team as a code owner November 19, 2024 20:50
@ykim-akamai ykim-akamai requested review from jriddle-linode and lgarber-akamai and removed request for a team November 19, 2024 20:50
Copy link
Contributor

@yec-akamai yec-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests passed locally!

@ezilber-akamai ezilber-akamai self-requested a review November 20, 2024 16:16
Copy link
Contributor

@ezilber-akamai ezilber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passed locally!

@ykim-akamai ykim-akamai merged commit 89fc86e into linode:dev Nov 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing for updates to the testing suite in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants