Skip to content

Address incompatibility between boto3 >= 1.36.x and third-party S3-compatible storage providers #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lgarber-akamai merged 1 commit into from
Jan 30, 2025
Merged

Address incompatibility between boto3 >= 1.36.x and third-party S3-compatible storage providers #718

lgarber-akamai merged 1 commit into from
Jan 30, 2025

Conversation

@lgarber-akamai
Copy link
Contributor

@lgarber-akamai lgarber-akamai commented Jan 30, 2025 •
edited
Loading

📝 Description

This pull request addresses an incompatibility between boto3 >= 1.36.x and third-part S3-compatible storage providers (including Akamai Compute).

Details on the incompatibility can be found here: boto/botocore#3352

✔️ How to Test

The following test steps assume you have pulled down this PR locally and run the following:

# Forcibly reinstall the optional dependencies (including boto3)
pip install --force .[dev,obj]
make install

Integration Testing

make TEST_SUITE=obj test-int

Manual Testing

N/A

@lgarber-akamai lgarber-akamai added the bugfix for any bug fixes in the changelog. label Jan 30, 2025
@lgarber-akamai lgarber-akamai marked this pull request as ready for review January 30, 2025 15:10
@lgarber-akamai lgarber-akamai requested a review from a team as a code owner January 30, 2025 15:10
@lgarber-akamai lgarber-akamai requested review from ezilber-akamai and zliang-akamai and removed request for a team January 30, 2025 15:10
lgarber-akamai
lgarber-akamai commented Jan 30, 2025
View reviewed changes
tests/integration/image/test_plugin_image_upload.py
TEST_IMAGE_CONTENT = (
b"\x1F\x8B\x08\x08\xBD\x5C\x91\x60\x00\x03\x74\x65\x73\x74\x2E\x69"
b"\x6D\x67\x00\x03\x00\x00\x00\x00\x00\x00\x00\x00\x00"
b"\x1f\x8b\x08\x08\xbd\x5c\x91\x60\x00\x03\x74\x65\x73\x74\x2e\x69"
Copy link
Contributor Author

@lgarber-akamai lgarber-akamai Jan 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was made implicitly by the formatter 🙂

ezilber-akamai
ezilber-akamai approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@ezilber-akamai ezilber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing locally!

yec-akamai
yec-akamai approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@yec-akamai yec-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passed locally!

@lgarber-akamai lgarber-akamai merged commit 634488f into linode:dev Jan 30, 2025
14 checks passed
@zliang-akamai zliang-akamai mentioned this pull request Feb 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yec-akamai yec-akamai yec-akamai approved these changes

@ezilber-akamai ezilber-akamai ezilber-akamai approved these changes

@zliang-akamai zliang-akamai Awaiting requested review from zliang-akamai zliang-akamai is a code owner automatically assigned from linode/dx

Assignees

No one assigned

Labels

bugfix for any bug fixes in the changelog.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lgarber-akamai @yec-akamai @ezilber-akamai