ref: Improve maintainability for baked request and response #729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yec-akamai
added
the
improvement
yec-akamai
requested review from
jriddle-linode and
ykim-akamai
and removed request for
a team
jriddle-linode
approved these changes
Feb 11, 2025
Collaborator
jriddle-linode
left a comment
jriddle-linode
left a comment
There was a problem hiding this comment.
Changes look good and good comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Improve the maintainability of baked/request.py and baked/response.py. Added/improved docstrings for all functions, methods, classes. Use static typing wherever possible. Added Inline comments for some confusing logics.