Skip to content

fix the failing test for Linode CLI #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vshanthe merged 3 commits into from
Apr 17, 2025
Merged

fix the failing test for Linode CLI #759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b8f4782
fix_failing_tests
vshanthe Apr 10, 2025
578c34b
fix_lint
vshanthe Apr 10, 2025
f17f0e7
Merge remote-tracking branch 'origin/dev' into test_fix
vshanthe Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tests/integration/domains/test_domains_tags.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@
# @pytest.mark.skip(reason="BUG 943")
def test_fail_to_create_master_domain_with_invalid_tags():
timestamp = str(time.time_ns())
bad_tag = "*"
bad_tag = (
"a" * 300
) # Tag validation rules changed — '*' is no longer rejected

exec_failing_test_command(
BASE_CMD
Expand Down
4 changes: 2 additions & 2 deletions tests/integration/lke/test_lke_enterprise.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def test_create_lke_enterprise(monkeypatch: MonkeyPatch):
"--tier",
"enterprise",
"--k8s_version",
"v1.31.1+lke1",
"v1.31.1+lke4",
"--node_pools.type",
"g6-standard-6",
"--node_pools.count",
Expand All @@ -74,7 +74,7 @@ def test_create_lke_enterprise(monkeypatch: MonkeyPatch):
assert_headers_in_lines(headers, output.splitlines())

assert label in output
assert "v1.31.1+lke1" in output
assert "v1.31.1+lke4" in output
assert "enterprise" in output

delete_target_id(
Expand Down
1 change: 1 addition & 0 deletions tests/integration/tags/test_tags.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ def test_view_unique_tag(test_tag_instance):
assert test_tag_instance in result


@pytest.mark.skip(reason="BUG = TPT-3650")
def test_fail_to_create_tag_shorter_than_three_char():
bad_tag = "aa"
result = exec_failing_test_command(
Expand Down