Remove invalid type annotation #808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zliang-akamai
added
the
improvement
zliang-akamai
requested review from
ezilber-akamai and
yec-akamai
and removed request for
a team
ezilber-akamai
approved these changes
Sep 3, 2025
yec-akamai
approved these changes
Sep 18, 2025
Contributor
yec-akamai
left a comment
yec-akamai
left a comment
There was a problem hiding this comment.
Thanks for fixing it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This is to fix a type annotation. The return type of the function with
@contextlib.contextmanagerdecorator will be handle by the decorator and annotated as the appropriate context manager type. Marking the return type of the inner function (the function under the decorator) is considered as an invalid type because the inner function never return a context manager but a generator (Generator[TextIOWrapper[_WrappedBuffer] | HTTPResponse | Any, Any, None]), which is also automatically detected by Python.✔️ How to Test
mypy linodecli/cli.pyWill return less errors than before. (And yes, it still returns tons of error (¬_¬"))