debian / libvirt / devconfig fixes #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uests Be sure to remove unattended-upgrades when taking the downloaded image from Debian to build our base image which we will use to launch guests with. The package unattended-upgrades [0] is one of the biggest pain points for continous integeration on kdevops, where we race against package installations being mucked behind our back. So let's just be extremely vocal about it being a requirement to not be installed on debian systems and complain and ensure systems don't have it. Even though we have already in place devconfig rules to remove it, upon first bringup you can still race against it! If you do have an old guest with it, you should just remove the old guest and re-do your new guest as otherwise you will encounter many odd silly bugs and the issue is just races with debian doing its upgrades with unattended-upgrades. To my surprise unattended-upgrades has also been a default on debian for years now, it would seem we can just move to a debian image of "netinst" or "minimal" images but that requires more work than what we can just do by removing the package. Long term we really should request to see if is debian folks can ends up packaging a proper guestfs image based on debian testing for us, and when that does happen we ask it does not have unattended-upgrades. [0] https://wiki.debian.org/UnattendedUpgrades Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
We already remove the package on debian bringups when downloading a an official but-not-guestfs-official (and so debian custom) image to build our base images for our guests. Now that we have that stop-gap measure, be sure we just fail if the package happens to be installed, and complain to the user about it. We can easily fix this with just two command so recommend that. Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
Turns out we define CONFIG_KDEVOPS_STORAGE_POOL_PATH only to make it be the
same as generic CONFIG_LIBVIRT_STORAGE_POOL_PATH only later to then
use the old GUESTFS_ARGS or VAGRANT_ARGS to define the yaml version with
a postfix "kdevops".
Fix all this mess by using yaml output and cleaing its use up.
This does not fix any bugs, it just make things consistent.
And so where you saw CONFIG_KDEVOPS_STORAGE_POOL_PATH we now just use
the generic version CONFIG_LIBVIRT_STORAGE_POOL_PATH.
The kconfig symbol CONFIG_KDEVOPS_STORAGE_POOL_PATH gets promoted to be
what we expect it, that is:
"{{ libvirt_storage_pool_path }}/kdevops"
This also ensure we will barf as we want to promote using ansible for
this anyway and do away with all of the CONFIG_KDEVOPS_STORAGE_POOL_PATH
uses in shell scripts.
This kills all use of CONFIG_KDEVOPS_STORAGE_POOL_PATH from shell
scripts too then.
The motivation for all this is to slowly trim away the large
error-prone script scripts/bringup_guestfs.sh into ansible. This
is just a small step towards making that easier.
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
This will be used later. Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
The bringup process for libvirt system URI support (not session), so all debian based distros, requieres us to be paranoid about the permissions of our storage directory where we place our libvirt storage pool, and guestfs images. We used to be stupid and were hammering with a sledge hammer a crazy sudo chown -R on a target storage path. That was removed by commit c31459d ("scripts/bringup_guestfs.sh: fix silly directory permission fix"). I rushed that change in because it was affecting live systems and we needed to get testing moving. This adds some sanity checks which don't do the crazy wild permission checks, it will just fail if the permissions are not right. Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
Folks trying to use kdevops and testing with fstests will quickly find out a surprise that their config is not being parsed correctly until later. Fix this by preventing bringup if the prefix has a dash. We use the dash to help parallelize testing filesystem profiles and so the host prefix goes before the filesystem name and test profile. Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
Author
|
Upstream branch: 0e172a8 |
kdevops-kpd
bot
force-pushed
the
main_base
branch
from
ea6130b to
c148677
Compare
Author
|
Upstream branch: 3521091 Pull request is NOT updated. Failed to apply https://patchwork.kernel.org/project/kdevops/list/?series=948301 conflict: |
kdevops-kpd
bot
force-pushed
the
main_base
branch
8 times, most recently
from
b6d2a44 to
a7241fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: debian / libvirt / devconfig fixes
version: 1
url: https://patchwork.kernel.org/project/kdevops/list/?series=946588