fix sc8280xp mccc definition #20
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
For sc8280xp/mc_cc we do not have a correct primary mux value. Currently the value is not used at all, since the GCC debug mux is not used for mccc measurement. Instead of programming the dummy value, skip programming it at all. TODO: consider reverting this commit if we find a necessity to use debug mux for mccc or other DDR clocks. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Merged
MarijnS95
approved these changes
May 1, 2023
Contributor
MarijnS95
left a comment
MarijnS95
left a comment
There was a problem hiding this comment.
I especially like cleaning up the inconsistent use of struct debug_mux *gcc = clk->primary; 😬
Collaborator
Author
|
Replaced by the chained muxes support. Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix the sc8280xp programming as suggested by @MarijnS95 at #18 (comment)