nvme: add --compat flag for 'gen-tls-key' and 'check-tls-key' #2896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igaw
reviewed
Aug 22, 2025
hreinecke
force-pushed
the
hkdf-fixes
branch
2 times, most recently
from
ccda2e6 to
ed9e8b9
Compare
Collaborator
|
The build fails, because there is no fallback version of these functions for |
Collaborator
Author
Should be fixed with linux-nvme/libnvme#1063 |
Update libnvme to include support for nvme_insert_tls_key_compat(). Signed-off-by: Hannes Reinecke <hare@suse.de>
Add a '--compat' flag for 'gen-tls-key' and 'check-tls-key' to allow interoperability with older implementations. Signed-off-by: Hannes Reinecke <hare@suse.de>
hreinecke
force-pushed
the
hkdf-fixes
branch
from
ed9e8b9 to
1a1c09c
Compare
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a '--compat' flag for 'gen-tls-key' and 'check-tls-key' to allow interoperability with older implementations.