Dev/master/travis #5
Conversation
|
Also there were 2 declarations for parsedebug. And no extern. I removed one and added an extern declaration as it seems the right thing to do. |
|
I enabled in travis-ci. |
|
Do you want from me to create such OAUTH token? |
|
That's your call. If you do, you'll get release tarballs automatically generated for you :) |
|
I'll get on OpenSM tomorrow (and probably do infiniband-diags too so we have all the linux-rdma tools in CI) |
It is not really my call, I have no intention to release anything besides rdma-core. |
1 similar comment
It is not really my call, I have no intention to release anything besides rdma-core. |
|
Note that infiniBand-diags is moving into rdma-core so I'm not sure you
need to do that.
…On Wed, Apr 17, 2019 at 8:11 PM Nicolas Morey-Chaisemartin < ***@***.***> wrote:
I'll get on OpenSM tomorrow (and probably do infiniband-diags too so we
have all the linux-rdma tools in CI)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#5 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AC2_GJu79LBudgaxnJWHcBQPPgMRkiLaks5vh1XOgaJpZM4c1YtI>
.
|
hnrose
left a comment
hnrose
left a comment
There was a problem hiding this comment.
Is libibverbs-dev needed ? ibsim doesn't use libibverbs AFAIK.
|
Manually merged first 3 patches. Only the travis patch remains which I'll test once I hear back on libibverbs-dev. |
nmorey
force-pushed
the
dev/master/travis
branch
from
ba6f961 to
e7dd23f
Compare
nmorey
force-pushed
the
dev/master/travis
branch
5 times, most recently
from
18b2c76 to
ccf6b94
Compare
|
Should be all good now :) |
|
Manually merged this patch series |
|
Thanks for doing the heavy lifting! |
ntohll is deprecated in libibumad. Use the glibc function instead Signed-off-by: Nicolas Morey-Chaisemartin <nmoreychaisemartin@suse.com>
Signed-off-by: Nicolas Morey-Chaisemartin <nmoreychaisemartin@suse.com>
Found by sparse Signed-off-by: Nicolas Morey-Chaisemartin <nmoreychaisemartin@suse.com>
Fixessparse warnings: subnet_discover.c:173:30: warning: non-ANSI function declaration of function 'free_unresponded' subnet_discover.c:564:26: warning: non-ANSI function declaration of function 'print_subnet' Signed-off-by: Nicolas Morey-Chaisemartin <nmoreychaisemartin@suse.com>
Found by GCC -Wall -Wextra Signed-off-by: Nicolas Morey-Chaisemartin <nmoreychaisemartin@suse.com>
Two issues here: - 2K on stack is a lot and app tends to segv in -O0 due to that. - libibmad is not honoring the size constraints on some mad_dump_xx. Increase buf to 8k to bypass this. Signed-off-by: Nicolas Morey-Chaisemartin <nmoreychaisemartin@suse.com>
This causes issues when doing
if(x)
dbg(...)
sparse found one of these:
mcast_storm.c:316:53: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
dbg("MAD status %x, method %x\n", status, method);
Signed-off-by: Nicolas Morey-Chaisemartin <nmoreychaisemartin@suse.com>
Signed-off-by: Nicolas Morey-Chaisemartin <nmoreychaisemartin@suse.com>
Allows to run ibsim in the background without stalling on readline calls Signed-off-by: Nicolas Morey-Chaisemartin <nmoreychaisemartin@suse.com>
Signed-off-by: Nicolas Morey-Chaisemartin <nmoreychaisemartin@suse.com>
Signed-off-by: Nicolas Morey-Chaisemartin <nmoreychaisemartin@suse.com>
nmorey
force-pushed
the
dev/master/travis
branch
from
ccf6b94 to
e9f2ed1
Compare
|
No problem. Here are some more patches to actually run some tests :) |
|
Wow! Manually merged the additional 12 patches. |
|
@hnrose If you want automated release tarball to be published on github, you'll need to follow the guide here: Or you can ping @rleon. I'm guessing he's familiar with this already :) |
3 participants
This works on my branch :)
Only thing you should need to do is go to:
https://travis-ci.org/organizations/linux-rdma/repositories
And enable it for ibsim.
I haven't enabled release publishing as it needs a token from someone with access to the repo.
See https://docs.travis-ci.com/user/deployment/releases/#authenticating-with-an-oauth-token for a howto.