Support for IPv6 address format in qperf tests #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b4182bc.
These code changes are done to include support for IPv6 address. Reviewed-by: Ka-Cheong Poon <ka-cheong.poon@oracle.com>
Contributor
|
Thanks, looks good to me. |
|
@hestela, A little late, but IMHO, adding a feature like IPv6 support probably warrants increasing the minor version, e.g., 0.4.10 -> 0.5.0. (Any idea why this is still at version zero?) Etiher way, can you add a tag and put the release on https://github.com/linux-rdma/qperf/releases? |
Open
drchristensen
added a commit
to drchristensen/qperf
that referenced
this pull request
Jun 4, 2020
Commit REQUIRES ipv6 on the system and server fails to bind to a port on a system with ipv6 disabled. This reverts commit c706363.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code changes so that qperf accepts both IPv4 and IPv6 addresses.