Skip to content

[PW_SID:930853] [v1] riscv: Use of_property_present() to test for non-boolean properties #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
linux-riscv-bot wants to merge 2 commits into from
Closed

[PW_SID:930853] [v1] riscv: Use of_property_present() to test for non-boolean properties #41

linux-riscv-bot wants to merge 2 commits into from

Conversation

@linux-riscv-bot
Copy link

@linux-riscv-bot linux-riscv-bot commented Feb 5, 2025

PR for series 930853 applied to workflow__riscv__fixes

Name: [v1] riscv: Use of_property_present() to test for non-boolean properties
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=930853
Version: 1

Linux RISC-V bot and others added 2 commits February 4, 2025 13:43
Adding CI files
b6ae2af
@esmil
riscv: Use of_property_present() to test for non-boolean properties
c7e648f 
The use of of_property_read_bool() for non-boolean properties is
deprecated and since

commit c141ecc ("of: Warn when of_property_read_bool() is used on non-boolean properties")

a warning is displayed when used incorrectly. Fix it by switching to
of_property_present() as recommended in the same commit.

Signed-off-by: Emil Renner Berthing <emil.renner.berthing@canonical.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Feb 5, 2025

Patch 1: "[v1] riscv: Use of_property_present() to test for non-boolean properties"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 122.71 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Feb 5, 2025

Patch 1: "[v1] riscv: Use of_property_present() to test for non-boolean properties"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1112.20 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Feb 5, 2025

Patch 1: "[v1] riscv: Use of_property_present() to test for non-boolean properties"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1375.04 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Feb 5, 2025

Patch 1: "[v1] riscv: Use of_property_present() to test for non-boolean properties"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 21.48 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Feb 5, 2025

Patch 1: "[v1] riscv: Use of_property_present() to test for non-boolean properties"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 22.73 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Feb 5, 2025

Patch 1: "[v1] riscv: Use of_property_present() to test for non-boolean properties"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.77 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Feb 5, 2025

Patch 1: "[v1] riscv: Use of_property_present() to test for non-boolean properties"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 45.28 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Feb 5, 2025

Patch 1: "[v1] riscv: Use of_property_present() to test for non-boolean properties"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Feb 5, 2025

Patch 1: "[v1] riscv: Use of_property_present() to test for non-boolean properties"
kdoc
Desc: Detects for kdoc errors
Duration: 0.89 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Feb 5, 2025

Patch 1: "[v1] riscv: Use of_property_present() to test for non-boolean properties"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Feb 5, 2025

Patch 1: "[v1] riscv: Use of_property_present() to test for non-boolean properties"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Feb 5, 2025

Patch 1: "[v1] riscv: Use of_property_present() to test for non-boolean properties"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

@linux-riscv-bot linux-riscv-bot deleted the pw930853 branch February 13, 2025 00:56
AlexGhiti pushed a commit that referenced this pull request May 13, 2025
@qsn @herbertx
crypto: scompress - increment scomp_scratch_users when already allocated
a32f192 
Commit ddd0a42 only increments scomp_scratch_users when it was 0,
causing a panic when using ipcomp:

    Oops: general protection fault, probably for non-canonical address 0xdffffc0000000000: 0000 [#1] SMP KASAN NOPTI
    KASAN: null-ptr-deref in range [0x0000000000000000-0x0000000000000007]
    CPU: 1 UID: 0 PID: 619 Comm: ping Tainted: G                 N  6.15.0-rc3-net-00032-ga79be02bba5c #41 PREEMPT(full)
    Tainted: [N]=TEST
    Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Arch Linux 1.16.3-1-1 04/01/2014
    RIP: 0010:inflate_fast+0x5a2/0x1b90
    [...]
    Call Trace:
     <IRQ>
     zlib_inflate+0x2d60/0x6620
     deflate_sdecompress+0x166/0x350
     scomp_acomp_comp_decomp+0x45f/0xa10
     scomp_acomp_decompress+0x21/0x120
     acomp_do_req_chain+0x3e5/0x4e0
     ipcomp_input+0x212/0x550
     xfrm_input+0x2de2/0x72f0
    [...]
    Kernel panic - not syncing: Fatal exception in interrupt
    Kernel Offset: disabled
    ---[ end Kernel panic - not syncing: Fatal exception in interrupt ]---

Instead, let's keep the old increment, and decrement back to 0 if the
scratch allocation fails.

Fixes: ddd0a42 ("crypto: scompress - Fix scratch allocation failure handling")
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
AlexGhiti pushed a commit that referenced this pull request Jun 2, 2025
@yangge1116-cpu @akpm00
mm/hugetlb: fix kernel NULL pointer dereference when replacing free h…
113ed54 
…ugetlb folios

A kernel crash was observed when replacing free hugetlb folios:

BUG: kernel NULL pointer dereference, address: 0000000000000028
PGD 0 P4D 0
Oops: Oops: 0000 [#1] SMP NOPTI
CPU: 28 UID: 0 PID: 29639 Comm: test_cma.sh Tainted 6.15.0-rc6-zp #41 PREEMPT(voluntary)
RIP: 0010:alloc_and_dissolve_hugetlb_folio+0x1d/0x1f0
RSP: 0018:ffffc9000b30fa90 EFLAGS: 00010286
RAX: 0000000000000000 RBX: 0000000000342cca RCX: ffffea0043000000
RDX: ffffc9000b30fb08 RSI: ffffea0043000000 RDI: 0000000000000000
RBP: ffffc9000b30fb20 R08: 0000000000001000 R09: 0000000000000000
R10: ffff88886f92eb00 R11: 0000000000000000 R12: ffffea0043000000
R13: 0000000000000000 R14: 00000000010c0200 R15: 0000000000000004
FS:  00007fcda5f14740(0000) GS:ffff8888ec1d8000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000000000028 CR3: 0000000391402000 CR4: 0000000000350ef0
Call Trace:
<TASK>
 replace_free_hugepage_folios+0xb6/0x100
 alloc_contig_range_noprof+0x18a/0x590
 ? srso_return_thunk+0x5/0x5f
 ? down_read+0x12/0xa0
 ? srso_return_thunk+0x5/0x5f
 cma_range_alloc.constprop.0+0x131/0x290
 __cma_alloc+0xcf/0x2c0
 cma_alloc_write+0x43/0xb0
 simple_attr_write_xsigned.constprop.0.isra.0+0xb2/0x110
 debugfs_attr_write+0x46/0x70
 full_proxy_write+0x62/0xa0
 vfs_write+0xf8/0x420
 ? srso_return_thunk+0x5/0x5f
 ? filp_flush+0x86/0xa0
 ? srso_return_thunk+0x5/0x5f
 ? filp_close+0x1f/0x30
 ? srso_return_thunk+0x5/0x5f
 ? do_dup2+0xaf/0x160
 ? srso_return_thunk+0x5/0x5f
 ksys_write+0x65/0xe0
 do_syscall_64+0x64/0x170
 entry_SYSCALL_64_after_hwframe+0x76/0x7e

There is a potential race between __update_and_free_hugetlb_folio() and
replace_free_hugepage_folios():

CPU1                              CPU2
__update_and_free_hugetlb_folio   replace_free_hugepage_folios
                                    folio_test_hugetlb(folio)
                                    -- It's still hugetlb folio.

  __folio_clear_hugetlb(folio)
  hugetlb_free_folio(folio)
                                    h = folio_hstate(folio)
                                    -- Here, h is NULL pointer

When the above race condition occurs, folio_hstate(folio) returns NULL,
and subsequent access to this NULL pointer will cause the system to crash.
To resolve this issue, execute folio_hstate(folio) under the protection
of the hugetlb_lock lock, ensuring that folio_hstate(folio) does not
return NULL.

Link: https://lkml.kernel.org/r/1747884137-26685-1-git-send-email-yangge1116@126.com
Fixes: 04f13d2 ("mm: replace free hugepage folios after migration")
Signed-off-by: Ge Yang <yangge1116@126.com>
Reviewed-by: Muchun Song <muchun.song@linux.dev>
Reviewed-by: Oscar Salvador <osalvador@suse.de>
Cc: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: Barry Song <21cnbao@gmail.com>
Cc: David Hildenbrand <david@redhat.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@linux-riscv-bot @esmil