Travis-CI + Coveralls #46

tyll · 2018-05-14T14:58:55Z

Add initial support for coveralls

pcahyna · 2018-05-14T15:51:12Z

I suggest renaming the test/ directory to tests/ while you are moving things around. tests/ is in the default role directory structure (try ansible-galaxy init).

tyll · 2018-05-14T16:07:35Z

For this we need linux-system-roles/test-harness@3dbfe29 to be deployed or we will break our CI. 2018-05-14 17:51 GMT+02:00 pcahyna <notifications@github.com>:

…

I suggest renaming the test/ directory to tests/ while you are moving things around. tests/ is in the default role directory structure (try ansible-galaxy init). — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#46 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAMEWP32TCTX6Kxu1nga0USSzSmzYNzJks5tyafwgaJpZM4T99gI> .

-- Till Maas Ansible RHEL Networking System Role Maintainer Red Hat GmbH

pcahyna · 2018-05-14T16:10:44Z

For this we need linux-system-roles/test-harness@3dbfe29 to be deployed or we will break our CI.

It has been deployed since a long time.

tyll · 2018-05-14T16:12:56Z

I mean the new code from the pull request, is it already running? 2018-05-14 18:10 GMT+02:00 pcahyna <notifications@github.com>:

…

For this we need ***@***.*** <linux-system-roles/test-harness@3dbfe29> to be deployed or we will break our CI. It has been deployed since a long time. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#46 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAMEWJ80TRccECInlyh-RrMPYXpMdIHsks5tyayOgaJpZM4T99gI> .

-- Till Maas Ansible RHEL Networking System Role Maintainer Red Hat GmbH

pcahyna · 2018-05-14T16:15:35Z

That's the point. It was deployed before being merged. I.e. the state of the CI does not correspond to the GitHub sources. Confusing, huh?

pcahyna · 2018-05-14T17:57:42Z

So it broke our CI, but for a different reason. The CI runs playbooks matching tests/tests*.yml (see linux-system-roles/test-harness@3dbfe29#diff-94b2ec369539eb75edac6313adb49eb8 and https://fedoraproject.org/wiki/CI/Standard_Test_Interface#Invocation ) and our tests do not match that.

tyll · 2018-05-14T18:43:05Z

Is there anything that I can follow/check to know about this? 2018-05-14 18:15 GMT+02:00 pcahyna <notifications@github.com>:

…

That's the point. It was deployed before being merged. I.e. the state of the CI does not correspond to the GitHub sources. Confusing, huh? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#46 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAMEWB3ydeKufe5UsL1KVho33Q_wP-kTks5tya2ogaJpZM4T99gI> .

-- Till Maas Ansible RHEL Networking System Role Maintainer Red Hat GmbH

tyll · 2018-05-14T18:51:30Z

It seems to me that the change for using tests/tests*.yml is not yet deployed because the logs are now nearly empty: https://larsu.fedorapeople.org/logs/linux-system-roles-network-pull-46-41f87fd-centos-6-20180514-184459/test.log

Compare to: https://larsu.fedorapeople.org/logs/linux-system-roles-network-pull-45-4bdffa3-fedora-25-20180509-103824/test.log

Or is there another error?

pcahyna · 2018-05-14T15:11:38Z

test/test_network_connections.py

@@ -7,7 +7,8 @@
 import socket
 import itertools

-sys.path.insert(1, os.path.dirname(os.path.abspath(__file__)))


I doubt this will work b/c in test_default.yml the module is imported from the same directory.

Sorry, I see the tests are passing - the line was must have been unnecessary, given that Python puts the directory of the script in the path by default.

I need the change to be able to run tox from the library/ directory for example.

I don't object against the change, I was just wondering why that line was ever there (and how removing it helps you with running anything, to me it seems like a no-op)

It is not removed but changed to the next line, which contains the correct value after the move. Not sure why it was there in the first place, though.

pcahyna · 2018-05-14T18:53:54Z

tests/test_default.yml

- name: Test executing the role with default parameters
-  hosts: all
-  roles:
-    - linux-system-roles.network


Tests seem to be gone, there are only deletions, no additions.

Thank you, too much rebase fun. This should be fixed now.

pcahyna · 2018-05-14T18:54:47Z

test/test_default.yml

- name: Test executing the role with default parameters
-  hosts: all
-  roles:
-    - linux-system-roles.network


Tests seem to be gone, there are deletions, no additions.

Thank you, too much rebase fun. This should be fixed now.

pcahyna · 2018-05-14T19:18:47Z

Could you please squash the commits which rename files so that every file is renamed at most once in the commit series? Right now some of the files are renamed several times.

tyll · 2018-05-15T10:21:25Z

I squashed the commits for the the new naming scheme and for travis/coveralls support. I kept the renaming of the test_network_connections.py separate since it is a different logical step. Therefore it is renamed twice.

Ansible Galaxy and https://fedoraproject.org/wiki/CI/Standard_Test_Interface suggest to use a /tests directory and a names matching test*.yml.

…o tests

Do not run coveralls by default and do not run flake8 and pylint in travis. They make it always fail at the moment.

tyll · 2018-05-17T09:16:49Z

I rebased it. Also I updated the tox.ini to also show the coverage in the terminal.

pcahyna · 2018-08-13T22:54:56Z

README.md

 linux-system-roles/network
 ==========================
+[![Coverage Status](https://coveralls.io/repos/github/linux-system-roles/network/badge.svg)](https://coveralls.io/github/linux-system-roles/network)
+[![Travis Build Status](https://travis-ci.org/linux-system-roles/network.svg?branch=master)](https://travis-ci.org/linux-system-roles/network)


I suggest to put the badges elsewhere because this does not look good when the source is used to generate user documentation in /usr/share/doc or similar.

What would the other place be? All other projects I know show the badges there so that visitors can get a fast overview. AFAIK there is no other way to display them on the repo's main page. Checking /usr/share/doc, there are several packages that show the badges in README.md there, for example rpmlint, asciinema, criu, fwupd, neovim, pandoc, ... (checked on my Fedora 28 system).

tyll force-pushed the coveralls branch from 441ed2a to 4c01128 Compare May 14, 2018 15:06

tyll changed the title ~~Coveralls~~ Travis-CI + Coveralls May 14, 2018

tyll mentioned this pull request May 14, 2018

DO NOT MERGE - TEST ONLY remove an apparently superfluous python path setting. #47

Closed

tyll force-pushed the coveralls branch from 4d08d8a to 8409099 Compare May 14, 2018 18:12

pcahyna reviewed May 14, 2018

View reviewed changes

tyll force-pushed the coveralls branch from 41f87fd to 71a6945 Compare May 14, 2018 19:09

tyll force-pushed the coveralls branch from 71a6945 to bbb835e Compare May 15, 2018 10:18

tyll force-pushed the coveralls branch from bbb835e to e28593a Compare May 16, 2018 13:45

tyll added 3 commits May 16, 2018 19:48

Move tests to /tests directory and rename to new naming scheme

4ead3cf

Ansible Galaxy and https://fedoraproject.org/wiki/CI/Standard_Test_Interface suggest to use a /tests directory and a names matching test*.yml.

Avoid symlink loop and nonstandard top level roles directory - move t…

3e6e536

…o tests

Move unit tests to tests dir

8e6f1bf

pcahyna mentioned this pull request May 16, 2018

Coveralls + directory move #48

Closed

tyll force-pushed the coveralls branch 2 times, most recently from 3064cc9 to 67e1f99 Compare May 17, 2018 09:13

tyll added 3 commits May 17, 2018 11:15

Add initial travis and coveralls support via tox

fb76fba

Do not run coveralls by default and do not run flake8 and pylint in travis. They make it always fail at the moment.

Add status badges

3ad7589

Update gitignore

8d014e7

tyll force-pushed the coveralls branch from 67e1f99 to 8d014e7 Compare May 17, 2018 09:15

tyll mentioned this pull request May 17, 2018

Unset the executable bit on Ansible modules. #45

Closed

pcahyna merged commit 9f00e45 into linux-system-roles:master May 17, 2018

tyll deleted the coveralls branch May 17, 2018 09:51

pcahyna reviewed Aug 13, 2018

View reviewed changes

Travis-CI + Coveralls #46

Travis-CI + Coveralls #46

Uh oh!

Conversation

tyll commented May 14, 2018

Uh oh!

pcahyna commented May 14, 2018

Uh oh!

tyll commented May 14, 2018 via email

Uh oh!

pcahyna commented May 14, 2018

Uh oh!

tyll commented May 14, 2018 via email

Uh oh!

pcahyna commented May 14, 2018

Uh oh!

pcahyna commented May 14, 2018

Uh oh!

tyll commented May 14, 2018 via email

Uh oh!

tyll commented May 14, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pcahyna commented May 14, 2018

Uh oh!

tyll commented May 15, 2018

Uh oh!

tyll commented May 17, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants