Skip to content

ci: Ansible version must be string, not float [citest_skip]#170

Merged
richm merged 1 commit intomainfrom
ensure-ansible-ver-is-string
Feb 17, 2026
Merged

ci: Ansible version must be string, not float [citest_skip]#170
richm merged 1 commit intomainfrom
ensure-ansible-ver-is-string

Conversation

@richm
Copy link
Contributor

@richm richm commented Feb 17, 2026

The ansible version is specified as a YAML floating point number. This causes
2.20 to be converted to 2.2 which breaks platforms that use ansible 2.20.
Ensure it and similar version numbers are specified in YAML as strings.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

CI:

  • Update the TFT GitHub Actions workflow matrix to specify Ansible versions as quoted strings for all listed platforms.

The ansible version is specified as a YAML floating point number.  This causes
`2.20` to be converted to `2.2` which breaks platforms that use ansible 2.20.
Ensure it and similar version numbers are specified in YAML as strings.

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm requested a review from spetrosi as a code owner February 17, 2026 19:30
@richm richm self-assigned this Feb 17, 2026
@sourcery-ai
Copy link

sourcery-ai bot commented Feb 17, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the GitHub Actions TFT workflow to represent Ansible versions as YAML strings instead of numeric literals, preventing unintended truncation of version numbers like 2.20 to 2.2 in the CI matrix.

Flow diagram for YAML version parsing before and after change

flowchart TD
  A[Load tft.yml] --> B[Parse YAML]
  B --> C{ansible_version type}

  C -->|"Numeric literal before"| D[Version 2.20 parsed as float 2.2]
  D --> E[CI uses wrong Ansible 2.2]
  E --> F[Playbook execution may fail]

  C -->|"Quoted string after"| G[Version '2.20' preserved as string]
  G --> H[CI uses correct Ansible 2.20]
  H --> I[Playbook execution matches expected platform support]
Loading

File-Level Changes

Change Details Files
Represent Ansible versions as strings in the GitHub Actions TFT workflow matrix to avoid YAML float parsing issues.
  • Updated all ansible_version entries in the matrix include list from numeric literals to quoted string values
  • Added an inline comment in the workflow to document that ansible_version must be a string to avoid float conversion issues
.github/workflows/tft.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider centralizing these Ansible version strings (e.g., via a matrix include anchor or reusable workflow) so you don't have to keep multiple, duplicated hard‑coded version lists in sync across future CI changes.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider centralizing these Ansible version strings (e.g., via a matrix include anchor or reusable workflow) so you don't have to keep multiple, duplicated hard‑coded version lists in sync across future CI changes.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm richm merged commit 31467b5 into main Feb 17, 2026
11 checks passed
@richm richm deleted the ensure-ansible-ver-is-string branch February 17, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant