Remove --env option

[acerv]

Remove --env option that was created to support multiple frameworks. Now that we support LTP environment only, we can fetch them directly from the OS environment like it was for runltp.

For instance, this will permits to do:

MYENV1=val1 MYENV2=val2 kirk --run-suite syscalls

instead of:

kirk --run-suite syscalls --env MYENV1=val1:MYENV2=val2

Closes: #72
Signed-off-by: Andrea Cervesato andrea.cervesato@suse.com
Tested-by: Li Wang mailto:liwang@redhat.com
Reviewed-by: Petr Vorel pvorel@suse.cz

[acerv]

@wangli5665 it would be nice if you can provide a feedback after testing this PR. Thanks!

[wangli5665]

Tested-by: Li Wang liwang@redhat.com

[pevik]

There will be always some variable missing (now it is LTP_NET_FEATURES_IGNORE_PERFORMANCE_FAILURE) if user uses older kirk than new variable in LTP Can't we just pass to SUT all variables which python3 sees and just filter few ones (UID, PWD)?

[acerv]

There will be always some variable missing (now it is LTP_NET_FEATURES_IGNORE_PERFORMANCE_FAILURE) if user uses older kirk than new variable in LTP Can't we just pass to SUT all variables which python3 sees and just filter few ones (UID, PWD)?

This is exactly why I asked a review about the code. I'm puzzled a bit due to the way we can inject environment variables to the tests binaries.

Either we inject all vars and remove a few ones, or we just inject the ones we know. Pros & Cons I guess. Inside a CI we might risk to expose sensitive environment variables to the tests, which is not the best.

[pevik]

Because kirk is in a separate project I would vote to inject all variables and filter these which would be problematic to inject.

[metan-ucw]

Given that all newly added variables are prefixed with 'LTP_' we can easily filter them by prefix.

[acerv]

Given that all newly added variables are prefixed with 'LTP_' we can easily filter them by prefix.

This is a good idea, I can keep non-standard prefix keys inside a lookup array and filter all vars starting with LTP_

[pevik]

Given that all newly added variables are prefixed with 'LTP_' we can easily filter them by prefix.

With 4 (5) non-LTP_ exceptions:

• KCONFIG_PATH
• KCONFIG_SKIP_CHECK
• LTPROOT
• PATH (not sure, but we need to allow to add special paths in SUT)
• TMPDIR

[acerv]

Given that all newly added variables are prefixed with 'LTP_' we can easily filter them by prefix.

With 4 (5) non-LTP_ exceptions:

* `KCONFIG_PATH`

* `KCONFIG_SKIP_CHECK`

* `LTPROOT`

* `PATH` (not sure, but we need to allow to add special paths in SUT)

* `TMPDIR`

I already sent a new commit for this